Summary: | [Mac] Assertion failure in collectComplexTextRunsForCharactersCoreText | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
Component: | Layout and Rendering | Assignee: | mitz | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | hyatt, mitz, thorton | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac (Intel) | ||||||
OS: | OS X 10.6 | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 77025 | ||||||
Attachments: |
|
Description
Ryosuke Niwa
2012-01-25 13:22:55 PST
Can you specify the platform and the OS version? (In reply to comment #1) > Can you specify the platform and the OS version? Snow Leopard. Looks like Core Text is acting up. We should not make this assertion, and if runFontData turns out to be 0, we should use the CTFont as returned (rather than doing the name lookup). Created attachment 131542 [details]
Handle the case of Core Text returning a fallback font that NSFontManager cannot find by name
Note that the test doesn’t trigger the assertion in all configurations, but that’s the closest I’ve been able to get. Comment on attachment 131542 [details] Handle the case of Core Text returning a fallback font that NSFontManager cannot find by name View in context: https://bugs.webkit.org/attachment.cgi?id=131542&action=review > Source/WebCore/ChangeLog:17 > + (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): Removed the > + failing assertion, which was not true, and added code to handle the case where a font > + cannot be found by name by using the font as returned from Core Text. The assertion is still there, did you mean to remove it? (In reply to comment #7) > (From update of attachment 131542 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=131542&action=review > > > Source/WebCore/ChangeLog:17 > > + (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): Removed the > > + failing assertion, which was not true, and added code to handle the case where a font > > + cannot be found by name by using the font as returned from Core Text. > > The assertion is still there, did you mean to remove it? I did, thanks! I’m going to do it before committing. Fixed in <http://trac.webkit.org/r110642>. |