Bug 77031

Summary:

[Qt] Inspector WebSocket backend protocol update

Product:

WebKit

Reporter:

Leo Franchi <leo>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hausmann, jturcotte, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

34598

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Updated/rebased patch for updated websocket protocol version	none
Updated/rebased patch for updated websocket protocol version	none

Leo Franchi

Reported 2012-01-25 11:20:30 PST

Inspector WebSocket backend protocol update

Attachments
Patch (12.46 KB, patch) 2012-01-25 11:24 PST, Leo Franchi	no flags	Details Formatted Diff Diff
Patch (11.72 KB, patch) 2012-01-25 11:48 PST, Leo Franchi	no flags	Details Formatted Diff Diff
Updated/rebased patch for updated websocket protocol version (11.24 KB, patch) 2012-09-11 07:05 PDT, Leo Franchi	no flags	Details Formatted Diff Diff
Updated/rebased patch for updated websocket protocol version (11.25 KB, patch) 2012-09-12 05:47 PDT, Leo Franchi	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Leo Franchi

Comment 1 2012-01-25 11:24:23 PST

Created attachment 123977 [details] Patch

Leo Franchi

Comment 2 2012-01-25 11:48:04 PST

Created attachment 123980 [details] Patch

Simon Hausmann

Comment 3 2012-09-06 22:42:03 PDT

Jocelyn, does this patch still apply, i.e. do we still need it? Apologies Leo, this one seems to have slipped through the cracks entirely. Hadn't noticed this patch since you uploaded it in January :(

Jocelyn Turcotte

Comment 4 2012-09-07 02:16:01 PDT

Oh, yes! Else it won't be possible to use the remote inspector at all for webkit1 since our client also got the new protocol.

Jocelyn Turcotte

Comment 5 2012-09-07 02:17:31 PDT

(In reply to comment #3) > Apologies Leo, this one seems to have slipped through the cracks entirely. Hadn't noticed this patch since you uploaded it in January :( My fault, I should have put myself on CC after I gave feedback to Leo about it on IRC :S

Leo Franchi

Comment 6 2012-09-07 05:14:49 PDT

I admit I also somewhat forgot about it too. Do I need to rebase and retest, has a lot of stuff changed over the last few months?

Jocelyn Turcotte

Comment 7 2012-09-07 06:27:18 PDT

There isn't probably much that changed, so it's more a matter of rebasing it and verify if it still works with a QtTestBrowser client.

Leo Franchi

Comment 8 2012-09-11 07:05:39 PDT

Created attachment 163354 [details] Updated/rebased patch for updated websocket protocol version

Leo Franchi

Comment 9 2012-09-11 07:07:19 PDT

Ok, I rebased the patch on current HEAD. I tested with QtTestBrowser---now with this patch I am able to connect to the remote web inspector both with QtTestBrowser and with a recent WebKit browser like Chrome v23. I don't remember the code super well as it was 9 months ago, so have a go at reviewing and I'll fix things up as they come up :)

WebKit Review Bot

Comment 10 2012-09-11 07:09:10 PDT

Attachment 163354 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/qt/ChangeLog', u'Source/WebK..." exit_code: 1 Source/WebKit/qt/WebCoreSupport/InspectorServerQt.cpp:195: Tab found; better to use spaces [whitespace/tab] [1] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.

Leo Franchi

Comment 11 2012-09-12 05:47:12 PDT

Created attachment 163606 [details] Updated/rebased patch for updated websocket protocol version Tab removed

WebKit Review Bot

Comment 12 2012-09-17 02:37:29 PDT

Comment on attachment 163606 [details] Updated/rebased patch for updated websocket protocol version Clearing flags on attachment: 163606 Committed r128731: <http://trac.webkit.org/changeset/128731>

WebKit Review Bot

Comment 13 2012-09-17 02:37:32 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.