Bug 77017

Summary: [Chromium]: rebaseline after r105878
Product: WebKit Reporter: Stephen Chenney <schenney>
Component: SVGAssignee: Stephen Chenney <schenney>
Status: RESOLVED FIXED    
Severity: Normal CC: antonm, leviw, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Stephen Chenney
Reported 2012-01-25 08:52:12 PST
Test expectations after r105878 are not right. This bug tracks rebaselining.
Attachments
Patch (1.92 KB, patch)
2012-01-25 09:25 PST, Stephen Chenney 		no flags
DetailsFormatted DiffDiff
Patch (51.88 KB, patch)
2012-01-25 13:01 PST, Stephen Chenney 		no flags
DetailsFormatted DiffDiff
Patch (33.99 KB, patch)
2012-01-26 09:54 PST, Stephen Chenney 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Stephen Chenney
Comment 1 2012-01-25 09:07:19 PST
This is more complicated than I thought. Windows and Mac results are wrong for one test. Investigating further.
anton muhin
Comment 2 2012-01-25 09:11:21 PST
maybe suppress tests for time being?
Stephen Chenney
Comment 3 2012-01-25 09:25:57 PST
Created attachment 123957 [details] Patch
Levi Weintraub
Comment 4 2012-01-25 09:44:01 PST
Comment on attachment 123957 [details] Patch Works for now.
anton muhin
Comment 5 2012-01-25 10:31:27 PST
Comment on attachment 123957 [details] Patch Clearing flags on attachment: 123957 Committed r105895: <http://trac.webkit.org/changeset/105895>
anton muhin
Comment 6 2012-01-25 10:31:36 PST
All reviewed patches have been landed. Closing bug.
anton muhin
Comment 7 2012-01-25 10:32:37 PST
Suppressions committed as http://trac.webkit.org/changeset/105895. Reopening for proper rebaseline
Stephen Chenney
Comment 8 2012-01-25 13:01:12 PST
Created attachment 123992 [details] Patch
Levi Weintraub
Comment 9 2012-01-25 13:04:05 PST
Comment on attachment 123992 [details] Patch Let's see how this goes.
Levi Weintraub
Comment 10 2012-01-25 13:09:13 PST
Comment on attachment 123992 [details] Patch Clearing flags on attachment: 123992 Committed r105921: <http://trac.webkit.org/changeset/105921>
Levi Weintraub
Comment 11 2012-01-25 13:09:18 PST
All reviewed patches have been landed. Closing bug.
Stephen Chenney
Comment 12 2012-01-26 09:52:18 PST
Expectations were broken again, and the lines in test_expectations also needed to be removed.
Stephen Chenney
Comment 13 2012-01-26 09:54:41 PST
Created attachment 124132 [details] Patch
Levi Weintraub
Comment 14 2012-01-26 09:57:15 PST
(In reply to comment #13) > Created an attachment (id=124132) [details] > Patch Why only text expectations this time?
WebKit Review Bot
Comment 15 2012-01-26 11:20:43 PST
Comment on attachment 124132 [details] Patch Clearing flags on attachment: 124132 Committed r106017: <http://trac.webkit.org/changeset/106017>
WebKit Review Bot
Comment 16 2012-01-26 11:20:49 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.