Bug 77014

Summary:

Web Inspector: Add InspectorClient::invalidateHostWindow()

Product:

WebKit

Reporter:

Alexander Pavlov (apavlov) <apavlov>

Component:

Web Inspector (Deprecated)

Assignee:

Alexander Pavlov (apavlov) <apavlov>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

aelias, apavlov, bweinstein, dglazkov, jamesr, joepeck, keishi, loislo, pfeldman, pmuellr, rakuco, rik, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

75963

Attachments:

Description	Flags
Patch	webkit.review.bot: commit-queue-

Alexander Pavlov (apavlov)

Reported 2012-01-25 08:46:27 PST

This method is necessary to downsize the FrameView when emulating mobile device resolutions.

Attachments
Patch (9.25 KB, patch) 2012-01-25 09:26 PST, Alexander Pavlov (apavlov)	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alexander Pavlov (apavlov)

Comment 1 2012-01-25 09:26:49 PST

Created attachment 123958 [details] Patch

Alexander Pavlov (apavlov)

Comment 2 2012-01-25 09:28:48 PST

We should also handle the Chromium-specific cases appropriately.

WebKit Review Bot

Comment 3 2012-01-25 10:23:08 PST

Comment on attachment 123958 [details] Patch Attachment 123958 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11159587 New failing tests: media/audio-garbage-collect.html

Pavel Feldman

Comment 4 2012-01-25 10:53:41 PST

What exactly do you need it for?

Alexander Pavlov (apavlov)

Comment 5 2012-01-25 11:00:34 PST

(In reply to comment #4) > What exactly do you need it for? This method is intended to erase the garbage left in the WebView (containing FrameView) after downsizing the child FrameView. This workflow has never been accounted for until now.

Pavel Feldman

Comment 6 2012-01-25 11:02:27 PST

(In reply to comment #5) > (In reply to comment #4) > > What exactly do you need it for? > > This method is intended to erase the garbage left in the WebView (containing FrameView) after downsizing the child FrameView. This workflow has never been accounted for until now. Could we always clear the WebView border upon FrameView downsizing?

Alexander Pavlov (apavlov)

Comment 7 2012-01-25 11:14:27 PST

(In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > What exactly do you need it for? > > > > This method is intended to erase the garbage left in the WebView (containing FrameView) after downsizing the child FrameView. This workflow has never been accounted for until now. > > Could we always clear the WebView border upon FrameView downsizing? WebView is a WebKit concept unlike FrameView, which is a WebCore class. All WebView implementations are platform-specific, as you may see. I'd be happy if there were a way. aelias@ told me yesterday: "for a pure WebKit solution, you'd have to fork the concept of FrameRect for website rendering/render tree, versus the one used for final painting", which can prove not so easy/good to implement, "as there might be a lot of code that assumes there's only one."

Alexander Pavlov (apavlov)

Comment 8 2012-03-20 04:30:17 PDT

This is not necessary for the currently selected approach.

Note You need to log in before you can comment on or make changes to this bug.