Bug 76972

Summary:

Move RenderLayer::size() calls to a common function

Product:

WebKit

Reporter:

Julien Chaffraix <jchaffraix>

Component:

Layout and Rendering

Assignee:

Julien Chaffraix <jchaffraix>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, hyatt, jamesr, simon.fraser, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

75568

Attachments:

Description	Flags
Proposed refactoring	none
Updated to ToT.	none
With a better naming after talking with Dave on IRC.	none

Description Julien Chaffraix 2012-01-24 18:05:20 PST

This is a second refactoring towards lazily allocating our layers as part of bug 75568.

Once all callers go through this new function we can add some layer() checks and some size caching scheme so that we can properly repaint without a layer.

Comment 1 Julien Chaffraix 2012-01-24 18:19:27 PST

Created attachment 123869 [details]
Proposed refactoring

Comment 2 Julien Chaffraix 2012-02-21 12:19:33 PST

Created attachment 128020 [details]
Updated to ToT.

Comment 3 Dave Hyatt 2012-02-22 14:00:28 PST

Comment on attachment 128020 [details]
Updated to ToT.

I don't like the term "cachedSize", since this is specifically about "the overflow clip layer size." I know you are going to stop making layers eventually, but maybe layerSize() is still an ok name to use.

Comment 4 Julien Chaffraix 2012-02-22 14:29:33 PST

Created attachment 128290 [details]
With a better naming after talking with Dave on IRC.

Comment 5 Julien Chaffraix 2012-02-28 13:26:48 PST

Adding more reviewers as this should be a simple change to review.

Comment 6 WebKit Review Bot 2012-02-28 15:09:27 PST

Comment on attachment 128290 [details]
With a better naming after talking with Dave on IRC.

Clearing flags on attachment: 128290

Committed r109157: <http://trac.webkit.org/changeset/109157>

Comment 7 WebKit Review Bot 2012-02-28 15:09:32 PST

All reviewed patches have been landed.  Closing bug.