Bug 76972

Summary: Move RenderLayer::size() calls to a common function
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: Layout and RenderingAssignee: Julien Chaffraix <jchaffraix>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, hyatt, jamesr, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 75568    
Attachments:
Description Flags
Proposed refactoring
none
Updated to ToT.
none
With a better naming after talking with Dave on IRC. none

Julien Chaffraix
Reported 2012-01-24 18:05:20 PST
This is a second refactoring towards lazily allocating our layers as part of bug 75568. Once all callers go through this new function we can add some layer() checks and some size caching scheme so that we can properly repaint without a layer.
Attachments
Proposed refactoring (6.72 KB, patch)
2012-01-24 18:19 PST, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
Updated to ToT. (6.80 KB, patch)
2012-02-21 12:19 PST, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
With a better naming after talking with Dave on IRC. (6.88 KB, patch)
2012-02-22 14:29 PST, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2012-01-24 18:19:27 PST
Created attachment 123869 [details] Proposed refactoring
Julien Chaffraix
Comment 2 2012-02-21 12:19:33 PST
Created attachment 128020 [details] Updated to ToT.
Dave Hyatt
Comment 3 2012-02-22 14:00:28 PST
Comment on attachment 128020 [details] Updated to ToT. I don't like the term "cachedSize", since this is specifically about "the overflow clip layer size." I know you are going to stop making layers eventually, but maybe layerSize() is still an ok name to use.
Julien Chaffraix
Comment 4 2012-02-22 14:29:33 PST
Created attachment 128290 [details] With a better naming after talking with Dave on IRC.
Julien Chaffraix
Comment 5 2012-02-28 13:26:48 PST
Adding more reviewers as this should be a simple change to review.
WebKit Review Bot
Comment 6 2012-02-28 15:09:27 PST
Comment on attachment 128290 [details] With a better naming after talking with Dave on IRC. Clearing flags on attachment: 128290 Committed r109157: <http://trac.webkit.org/changeset/109157>
WebKit Review Bot
Comment 7 2012-02-28 15:09:32 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.