Summary: | Support a suffix on ChangeLog filenames based on a configuration file | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||||
Component: | Tools / Tests | Assignee: | Benjamin Poulain <benjamin> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ddkilzer, haraken, webkit.review.bot | ||||||
Priority: | P2 | Keywords: | EasyFix, InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Benjamin Poulain
2012-01-24 16:19:05 PST
Created attachment 123842 [details]
Patch
Warning: I am not at all familiar with Perl. Please be careful when reviewing :) Comment on attachment 123842 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123842&action=review The approach looks OK to me, but I am not sure if the scripts we need to modify are only resolve-ChangeLogs, prepare-ChangeLog and commit-log-editor? There are other scripts that contain "ChangeLog". ($ grep -rl '"ChangeLog"' Tools/Scripts/*) > Tools/Scripts/VCSUtils.pm:1765 > + open FILE, File::Spec->catfile($rootPath, "ChangeLogSuffix") or die "Could not open $changeLogSuffixFile: $!"; This should be open FILE, $changeLogSuffixFile or die "Could not open $changeLogSuffixFile: $!"; > Tools/Scripts/VCSUtils.pm:1767 > + my $changeLogSuffix = <FILE>; > + close FILE; Let's strip trailing \n, like this: my $changeLogSuffix = <FILE>; chomp $changeLogSuffix; close FILE; Created attachment 124178 [details]
Patch
Thanks for looking into this. I fixed the error you discovered.
> View in context: https://bugs.webkit.org/attachment.cgi?id=123842&action=review
>
> The approach looks OK to me, but I am not sure if the scripts we need to modify are only resolve-ChangeLogs, prepare-ChangeLog and commit-log-editor? There are other scripts that contain "ChangeLog". ($ grep -rl '"ChangeLog"' Tools/Scripts/*)
I intentionally ignore webkitpy and changed the minimal set of tools we need. This is solving one particular problem instead of fully supporting a complete new feature for the tools.
(In reply to comment #5) > > The approach looks OK to me, but I am not sure if the scripts we need to modify are only resolve-ChangeLogs, prepare-ChangeLog and commit-log-editor? There are other scripts that contain "ChangeLog". ($ grep -rl '"ChangeLog"' Tools/Scripts/*) > > I intentionally ignore webkitpy and changed the minimal set of tools we need. This is solving one particular problem instead of fully supporting a complete new feature for the tools. Makes sense. Thank you for the patch! Comment on attachment 124178 [details] Patch Clearing flags on attachment: 124178 Committed r106054: <http://trac.webkit.org/changeset/106054> All reviewed patches have been landed. Closing bug. |