| Summary: | Update pixel table test expectations for mac to match new DRT scrollbars | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Emil A Eklund <eae> | ||||||
| Component: | Tools / Tests | Assignee: | Emil A Eklund <eae> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, eric, jchaffraix, leviw, simon.fraser | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Mac | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Emil A Eklund
2012-01-24 13:15:50 PST
Created attachment 123793 [details]
Patch
Created attachment 123795 [details]
Patch
Simon, could you take a quick look at this to make sure it's right? Thanks! The baselines look good to me but I don't know enough of the mac port to know if all are needed or if some sharing could happen. We have scripts which handle sharing. webkit-patch optimize-baselines or something like that. rs=me. I can't actually get the review page to load. FYI, I did look at them sometimes ago (the page is super long to load): the new baselines did make sense (just some scrollbars differences). I just wasn't sure about the 'why didn't we already had those baselines?' part but forgot to point it out here. Is this a blanket update, or did you eyeball each result to ensure that you're not hiding existing failures? (In reply to comment #8) > Is this a blanket update, or did you eyeball each result to ensure that you're not hiding existing failures? I checked each result to make sure that the only change was to the scrollbars. Committed r107122: <http://trac.webkit.org/changeset/107122> |