Bug 76938

Summary: Update pixel table test expectations for mac to match new DRT scrollbars
Product: WebKit Reporter: Emil A Eklund <eae>
Component: Tools / TestsAssignee: Emil A Eklund <eae>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, jchaffraix, leviw, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Emil A Eklund
Reported 2012-01-24 13:15:50 PST
Update pixel test expectations for the mozilla table tests in response to the mock scrollbars introduced in bug 67217.
Attachments
Patch (deleted)
2012-01-24 13:27 PST, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Patch (deleted)
2012-01-24 13:31 PST, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Emil A Eklund
Comment 1 2012-01-24 13:27:12 PST
Created attachment 123793 [details] Patch
Emil A Eklund
Comment 2 2012-01-24 13:31:52 PST
Created attachment 123795 [details] Patch
Emil A Eklund
Comment 3 2012-01-25 09:41:34 PST
Simon, could you take a quick look at this to make sure it's right? Thanks!
Julien Chaffraix
Comment 4 2012-01-28 15:21:13 PST
The baselines look good to me but I don't know enough of the mac port to know if all are needed or if some sharing could happen.
Eric Seidel (no email)
Comment 5 2012-02-07 13:12:14 PST
We have scripts which handle sharing. webkit-patch optimize-baselines or something like that.
Eric Seidel (no email)
Comment 6 2012-02-07 13:47:30 PST
rs=me. I can't actually get the review page to load.
Julien Chaffraix
Comment 7 2012-02-07 13:52:40 PST
FYI, I did look at them sometimes ago (the page is super long to load): the new baselines did make sense (just some scrollbars differences). I just wasn't sure about the 'why didn't we already had those baselines?' part but forgot to point it out here.
Simon Fraser (smfr)
Comment 8 2012-02-08 00:39:10 PST
Is this a blanket update, or did you eyeball each result to ensure that you're not hiding existing failures?
Emil A Eklund
Comment 9 2012-02-08 11:15:26 PST
(In reply to comment #8) > Is this a blanket update, or did you eyeball each result to ensure that you're not hiding existing failures? I checked each result to make sure that the only change was to the scrollbars.
Emil A Eklund
Comment 10 2012-02-08 12:42:30 PST
Committed r107122: <http://trac.webkit.org/changeset/107122>
Note You need to log in before you can comment on or make changes to this bug.