Bug 76923

Summary: [Refactoring] In CodeGeneratorGObject.pm, merge GeneratePrivateHeader() into WriteData()
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, darin, japhet, mrobinson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 76836    
Attachments:
Description Flags
Patch none

Kentaro Hara
Reported 2012-01-24 10:22:26 PST
This is one of steps to stop rebuilding .h/.cpp files generated by unchanged IDLs (bug 76836). In CodeGeneratorGObject.pm, we can merge GeneratePrivateHeader() into WriteData(), so that all code to output .h/.cpp is managed by WriteData(), just like other CodeGenerator*.pm does.
Attachments
Patch (5.94 KB, patch)
2012-01-24 10:48 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-01-24 10:48:07 PST
Created attachment 123768 [details] Patch
WebKit Review Bot
Comment 2 2012-01-24 13:44:00 PST
Comment on attachment 123768 [details] Patch Clearing flags on attachment: 123768 Committed r105803: <http://trac.webkit.org/changeset/105803>
WebKit Review Bot
Comment 3 2012-01-24 13:44:05 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.