Summary: | [Qt] run-qtwebkit-tests should report crashes | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||||||||
Component: | Tools / Tests | Assignee: | Ádám Kallai <kadam> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Critical | CC: | jturcotte, ossy | ||||||||||
Priority: | P1 | Keywords: | Qt, QtTriaged | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Attachments: |
|
Description
Csaba Osztrogonác
2012-01-24 04:48:06 PST
Created attachment 127970 [details]
draft of solution
The patch is not complete yet. It's a draft, any kind of help or ideas are appreciated. :)
Added checking of crashing tests. TOTALS now includes the total number of crashing tests too. Missing sub-summary is considered as a crash. Test object with "None" output is now handled. I commented off convert_to_html function, because these modifications are to be made here too.
I induced the crash with exit(1) in an API test (tst_qquickwebview.cpp) so I could test this.
Created attachment 128671 [details]
proposed patch
I added my modification to convert_to_html function too.
Created attachment 129222 [details]
proposed patch
I have finished the patch. Made unit test for this modification.
Comment on attachment 129222 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=129222&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:87 > + > + def assertSummary(self, expected_text, stdio): > + rc = 0 > + cmd = StubRemoteCommand(rc, stdio) > + #step = RunQtWebKitTests() > + Is this accidentally in the patch? Created attachment 129228 [details]
proposed patch
Thanks for comment. It was there accidentally. It has been fixed.
Comment on attachment 129228 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=129228&action=review r=me with removing accidentally uploaded code. > Tools/ChangeLog:16 > + (RunQtAPITestsTest.assertSummary): Remove it too. > Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:87 > + > + def assertSummary(self, expected_text, stdio): > + rc = 0 > + cmd = StubRemoteCommand(rc, stdio) > + #step = RunQtWebKitTests() > + We still don't need this code. :) Landed in http://trac.webkit.org/changeset/112383 |