| Summary: | [chromium] Add <(SHARED_INTERMEDIATE_DIR)/webkit to include path of targets that depend on WebKit API so they pick up the copied headers in an onion build | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | James Robinson <jamesr> | ||||||
| Component: | New Bugs | Assignee: | James Robinson <jamesr> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | ||||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
James Robinson
2012-01-23 16:36:20 PST
Created attachment 123655 [details]
Patch
The particular problem this solves is that this target: http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/ppapi_shared.gypi?view=markup has a dependency directly on <(webkit_src_dir)/Source/WebKit/chromium/WebKit.gyp:webkit and files with includes that look like #include "third_party/WebKit/Source/WebKit/...". In a chromium-inside-WebKit checkout we resolve includes by this by generating copies of headers into <(SHARED_INTERMEDIATE_DIR)/webkit/third_party/WebKit/... via the setup_third_party.py script in webkit_support. Most (all?) targets in webkit/*/ add this include_dir in other ways, so this only impacts chromium code that directly depends on third_party/WebKit/... which is probably why we haven't seen it in other places. Comment on attachment 123655 [details]
Patch
please wrap this in a inside_chromium_build==0 block.
Created attachment 123661 [details]
Patch
Committed r105662: <http://trac.webkit.org/changeset/105662> |