|Summary:||Avoid spurious rebuilds on vs2010 due to DerivedSources not existing|
|Product:||WebKit||Reporter:||Scott Graham <scottmg>|
|Component:||Tools / Tests||Assignee:||Scott Graham <scottmg>|
|Version:||528+ (Nightly build)|
Description Scott Graham 2012-01-23 16:05:40 PST
I'm not sure if this is the correct fix. On Chromium Windows, the files in DerivedSources don't appear to get generated (see WebCore.gypi) so not including them means avoiding spurious rebuilds.
Comment 2 Scott Graham 2012-01-23 16:16:29 PST
Reference was added here: https://bugs.webkit.org/show_bug.cgi?id=56604
Comment 3 Adam Barth 2012-01-23 16:20:18 PST
Comment on attachment 123647 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123647&action=review > Source/WebCore/WebCore.gyp/WebCore.gyp:-1828 > - '<@(webcore_privateheader_files)', This isn't correct. If there are specific files we need to remove that don't exist, we should remove them in the gypi. This line of code should stay here as far as I understand things.
Comment 5 Scott Graham 2012-01-23 16:33:25 PST
This is the other alternative then. I don't have any DerivedSources in my build, unless it's from building a config or variant of some sort? In any case, they're all headers so it shouldn't affect correctness anyway.
Comment 6 Adam Barth 2012-01-23 16:34:30 PST
Comment on attachment 123653 [details] Patch Ah, ok. If we resurrect the AppleMac GYP build, we'll need to do something slightly more clever here.
Comment 7 Adam Barth 2012-01-23 16:35:02 PST
Comment 8 WebKit Review Bot 2012-01-23 23:38:51 PST
Comment on attachment 123653 [details] Patch Clearing flags on attachment: 123653 Committed r105700: <http://trac.webkit.org/changeset/105700>
Comment 9 WebKit Review Bot 2012-01-23 23:38:56 PST
All reviewed patches have been landed. Closing bug.