Bug 76873

Summary: Avoid spurious rebuilds on vs2010 due to DerivedSources not existing
Product: WebKit Reporter: Scott Graham <scottmg>
Component: Tools / TestsAssignee: Scott Graham <scottmg>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Scott Graham
Reported 2012-01-23 16:05:40 PST
I'm not sure if this is the correct fix. On Chromium Windows, the files in DerivedSources don't appear to get generated (see WebCore.gypi) so not including them means avoiding spurious rebuilds.
Attachments
Patch (1.13 KB, patch)
2012-01-23 16:11 PST, Scott Graham 		no flags
DetailsFormatted DiffDiff
Patch (33.79 KB, patch)
2012-01-23 16:32 PST, Scott Graham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Scott Graham
Comment 1 2012-01-23 16:11:20 PST
Created attachment 123647 [details] Patch
Scott Graham
Comment 2 2012-01-23 16:16:29 PST
Reference was added here: https://bugs.webkit.org/show_bug.cgi?id=56604
Adam Barth
Comment 3 2012-01-23 16:20:18 PST
Comment on attachment 123647 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123647&action=review > Source/WebCore/WebCore.gyp/WebCore.gyp:-1828 > - '<@(webcore_privateheader_files)', This isn't correct. If there are specific files we need to remove that don't exist, we should remove them in the gypi. This line of code should stay here as far as I understand things.
Scott Graham
Comment 4 2012-01-23 16:32:06 PST
Created attachment 123653 [details] Patch
Scott Graham
Comment 5 2012-01-23 16:33:25 PST
This is the other alternative then. I don't have any DerivedSources in my build, unless it's from building a config or variant of some sort? In any case, they're all headers so it shouldn't affect correctness anyway.
Adam Barth
Comment 6 2012-01-23 16:34:30 PST
Comment on attachment 123653 [details] Patch Ah, ok. If we resurrect the AppleMac GYP build, we'll need to do something slightly more clever here.
Adam Barth
Comment 7 2012-01-23 16:35:02 PST
Thanks!
WebKit Review Bot
Comment 8 2012-01-23 23:38:51 PST
Comment on attachment 123653 [details] Patch Clearing flags on attachment: 123653 Committed r105700: <http://trac.webkit.org/changeset/105700>
WebKit Review Bot
Comment 9 2012-01-23 23:38:56 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.