|
Description
Gavin Barraclough
2012-01-23 13:04:58 PST
Created attachment 123631 [details]
Pt2, generalize RedBlackTree
Created attachment 123632 [details]
Ooops, revert unnecessary change to MetaAllocatorHandle
Comment on attachment 123632 [details] Ooops, revert unnecessary change to MetaAllocatorHandle View in context: https://bugs.webkit.org/attachment.cgi?id=123632&action=review r=me > Source/JavaScriptCore/ChangeLog:8 > + Step 2: generalize RedBlackTree. The profiler is going to want tio use Typo: tio. Oooops, shouldn't have marked as fixed yet! Also, build fix in r105666. Created attachment 123845 [details]
Add mechanism to MetaAllocator to allow allocations to be tracked.
Created attachment 124378 [details]
The profiler. Will probably require some PLATFORM(MAC) guards to make this compiler on non-OS X builds.
Attachment 124378 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/jit/ExecutableAllocatorFixedVMPool.cpp:36: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 18 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 124378 [details] The profiler. Will probably require some PLATFORM(MAC) guards to make this compiler on non-OS X builds. Attachment 124378 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11359180 Comment on attachment 124378 [details] The profiler. Will probably require some PLATFORM(MAC) guards to make this compiler on non-OS X builds. Attachment 124378 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/11359190 Created attachment 124391 [details]
Build fixes (patch already reviewed by oliver)
Attachment 124391 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'S..." exit_code: 1
Source/JavaScriptCore/Target.pri:212: Line contains tab character. [whitespace/tab] [5]
Source/JavaScriptCore/Target.pri:213: Line contains tab character. [whitespace/tab] [5]
Source/JavaScriptCore/CMakeLists.txt:203: Line contains tab character. [whitespace/tab] [5]
Source/JavaScriptCore/CMakeLists.txt:204: Line contains tab character. [whitespace/tab] [5]
Source/JavaScriptCore/jit/ExecutableAllocatorFixedVMPool.cpp:34: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 5 in 22 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 124398 [details]
More build fixes (patch already reviewed by oliver)
Comment on attachment 124398 [details] More build fixes (patch already reviewed by oliver) Attachment 124398 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11359226 Created attachment 124403 [details]
More build fixes (patch already reviewed by oliver)
Created attachment 124404 [details]
More build fixes (patch already reviewed by oliver)
Comment on attachment 124404 [details] More build fixes (patch already reviewed by oliver) Attachment 124404 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11359241 Comment on attachment 124404 [details] More build fixes (patch already reviewed by oliver) Attachment 124404 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11358356 Comment on attachment 124404 [details] More build fixes (patch already reviewed by oliver) Attachment 124404 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/11358358 Created attachment 124411 [details]
More build fixes (patch already reviewed by oliver)
Comment on attachment 124411 [details] More build fixes (patch already reviewed by oliver) Attachment 124411 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11360226 Comment on attachment 124411 [details] More build fixes (patch already reviewed by oliver) Attachment 124411 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11191933 Created attachment 124418 [details]
More build fixes (patch already reviewed by oliver)
Created attachment 124421 [details]
More build fixes (patch already reviewed by oliver)
Comment on attachment 124421 [details] More build fixes (patch already reviewed by oliver) Attachment 124421 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11360243 Created attachment 124423 [details]
More build fixes (patch already reviewed by oliver)
Comment on attachment 124423 [details] More build fixes (patch already reviewed by oliver) Attachment 124423 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/11360246 Created attachment 124430 [details]
More build fixes (patch already reviewed by oliver)
Fixed in r106197 (In reply to comment #30) > Fixed in r106197 This broke the TestWebKitAPI build: <http://build.webkit.org/builders/Lion%20Intel%20Debug%20%28Tests%29/builds/3058/steps/run-api-tests/logs/stdio/text>. build fix in r106264. Interpreter build fixed in r106276 |