Range.getClientRects() should not include rects for partially selected elements

• Component: DOM
• Status: RESOLVED FIXED

[JuanCar Gallego]

Range.getclientrects returns too much rects, some of them incorrect (out of the range), at least when:
 - the end point of the range (endOffset) doesn't match the last position of the endContainer element
 - AND the beguinning of the endContainer is included in the range, but it's not the startOffset
In addition of the range rects, it's returning the rects of the whole endContainer element.

Tested in Chrome and Safari, working right in FireFox.

Described with an example here:
http://stackoverflow.com/questions/7232723/semantics-of-clientrect-from-getclientrects-in-webkit-browsers

[theTestTube]

Subscribe this.

I'm afraid we're also suffering it with Chrome and Safari.-

[JuanCar Gallego]

More information.

It seems like two close problems:

1. Range.getClientRects return rects for the partially selected text nodes in the startContaniner and endContainer. Correct. But for the not border elements it returns both rects for the whole elements, and rects for any text "fragment" inside them. It's redundant and confusing, and I think uncompliant with http://www.w3.org/TR/cssom-view/#extensions-to-the-range-interface

2. Correcting my first description of the problem: When endContainer is partially selected, and endContainer doesn't match startContainer, Range.getClientRects returns rect for the topmost ancestor of the endContainer whose parent contains the whole range (the child of range.commonAncestorContainer containing or being endContainer). This is clearly an error, because part of that rect (remember endContainer is partially selected) is outside the range.

[Andy Estes]

<rdar://problem/13387823>

[JuanCar Gallego]

(In reply to comment #3)
> <rdar://problem/13387823>

Hi, Andy.
I'm not sure to understand why you changed the subject of the bug.
IMHO not returning any rects for partially selected elements is worst than returning partial and total rects. With actual behaviour, at least I'm able to detect and discard wrong rects.

[Andy Estes]

Created attachment 199012 [details]
Patch

[Andy Estes]

(In reply to comment #4)
> (In reply to comment #3)
> > <rdar://problem/13387823>
> 
> Hi, Andy.
> I'm not sure to understand why you changed the subject of the bug.
> IMHO not returning any rects for partially selected elements is worst than returning partial and total rects. With actual behaviour, at least I'm able to detect and discard wrong rects.

You will still get rects for the selected children of the partially selected element.

[JuanCar Gallego]

(In reply to comment #6)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > <rdar://problem/13387823>
> > 
> > Hi, Andy.
> > I'm not sure to understand why you changed the subject of the bug.
> > IMHO not returning any rects for partially selected elements is worst than returning partial and total rects. With actual behaviour, at least I'm able to detect and discard wrong rects.
> 
> You will still get rects for the selected children of the partially selected element.

If it includes portions of partially selected text elements, as it does now, that's fine. Thank you.

[Andy Estes]

Committed r148898: <http://trac.webkit.org/changeset/148898>