Bug 76744

Summary: [windows] Convert usages of GetDC to HWndDC Part 1.
Product: WebKit Reporter: David Levin <levin>
Component: PlatformAssignee: David Levin <levin>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, ddkilzer, dslomov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 76303    
Attachments:
Description Flags
Patch
none
Patch none

Description David Levin 2012-01-20 15:00:01 PST 
These are the files where all conversions are straightforward and simple.
Comment 1 David Levin 2012-01-20 15:02:27 PST 
Created attachment 123385 [details]
Patch
Comment 2 David Levin 2012-01-20 15:24:37 PST 
Created attachment 123394 [details]
Patch
Comment 3 Dmitry Lomov 2012-01-20 16:08:36 PST 
Comment on attachment 123394 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123394&action=review

Nice!

> Source/WebCore/platform/win/CursorWin.cpp:54
>      HDC workingDC = CreateCompatibleDC(dc);

This will be replaced with OwnDC at some point right?
Comment 4 David Levin 2012-01-20 16:18:04 PST 
(In reply to comment #3)
> This will be replaced with OwnDC at some point right?

Ideally there would be a pass to do that. I'm not going to do that for now. (Spent too much time on this now.) I thought about filling a bug but I'm not sure it would do any good.

However, there is a style check now which will encourage the right behavior!
Comment 5 Adam Roben (:aroben) 2012-01-23 08:26:00 PST 
Comment on attachment 123394 [details]
Patch

Thanks for splitting this up!
Comment 6 WebKit Review Bot 2012-01-23 17:07:58 PST 
Comment on attachment 123394 [details]
Patch

Clearing flags on attachment: 123394

Committed r105661: <http://trac.webkit.org/changeset/105661>
Comment 7 WebKit Review Bot 2012-01-23 17:08:02 PST 
All reviewed patches have been landed.  Closing bug.