Bug 76728

Summary: [chromium] Plumb damage from accelerated canvas 2D.
Product: WebKit Reporter: Jonathan Backer <backer>
Component: New BugsAssignee: Jonathan Backer <backer>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cc-bugs, jamesr, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jonathan Backer
Reported 2012-01-20 12:39:08 PST
[chromium] Plumb damage from accelerated canvas 2D.
Attachments
Patch (1.29 KB, patch)
2012-01-20 12:39 PST, Jonathan Backer 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jonathan Backer
Comment 1 2012-01-20 12:39:38 PST
Created attachment 123363 [details] Patch
Shawn Singh
Comment 2 2012-01-20 12:44:14 PST
Comment on attachment 123363 [details] Patch Thanks for this, LGTM. Somehow this line of code disappeared since I had added it a few months ago. And the new placement of this line seems good, too, but perhaps jamesr should take a look and verify.
Adrienne Walker
Comment 3 2012-01-20 13:41:15 PST
Comment on attachment 123363 [details] Patch LGTM.
Kenneth Russell
Comment 4 2012-01-20 13:42:47 PST
Comment on attachment 123363 [details] Patch rs=me based on enne's review.
WebKit Review Bot
Comment 5 2012-01-20 14:50:05 PST
Comment on attachment 123363 [details] Patch Clearing flags on attachment: 123363 Committed r105544: <http://trac.webkit.org/changeset/105544>
WebKit Review Bot
Comment 6 2012-01-20 14:50:10 PST
All reviewed patches have been landed. Closing bug.
James Robinson
Comment 7 2012-01-20 16:11:58 PST
This is fine, but in the future if somebody wants to tighten up the bounds you can take a look at propagating the dirtyRect from CanvasRenderingContext2D::didDraw() through to this logic rather than considering the whole canvas dirty.
Note You need to log in before you can comment on or make changes to this bug.