Bug 76722 – Garden-o-matic should tell me which revisions have been checked by all the bots

• Component: New Bugs
• Status: RESOLVED FIXED

[Adam Barth]

Garden-o-matic should tell me which revisions have been checked by all the bots

[Adam Barth]

Created attachment 123349 [details]
Patch

[Adam Barth]

Committed r105530: <http://trac.webkit.org/changeset/105530>

[Adam Roben (:aroben)]

Comment on attachment 123349 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123349&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:148
> +    var revision = 0;
> +    Object.keys(model.state.resultsByBuilder).forEach(function(builderName) {
> +        var results = model.state.resultsByBuilder[builderName];
> +        var testedRevision = parseInt(results.revision);
> +        revision = revision ? Math.min(revision, testedRevision) : testedRevision;
> +    });
> +    return revision;

Aww, so close to total functional goodness!

var revisions = Object.keys(model.state.resultsByBuilder).map(function(builderName) {
    var results = model.state.resultsByBuilder[builderName];
    var testedRevision = parseInt(results.revision);
    return revision ? revision : 1e100;
});
return Math.min.apply(Math, revisions);

:-)

[Adam Roben (:aroben)]

Or you could use Array.prototype.filter to get rid of the non-revisions instead of substituting a large number for them…

</bikeshed>

[Adam Barth]

:-)