Bug 76678

Summary: [Chromium] Fix potential flashes when page is loading
Product: WebKit Reporter: Daniel Sievers <sievers>
Component: New BugsAssignee: Daniel Sievers <sievers>
Status: RESOLVED WONTFIX    
Severity: Normal CC: jamesr, klobag, schenney, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Daniel Sievers
Reported 2012-01-19 17:52:59 PST
[Chromium] Fix potential flashes when page is loading
Attachments
Patch (2.74 KB, patch)
2012-01-19 17:56 PST, Daniel Sievers 		no flags
DetailsFormatted DiffDiff
Patch (2.77 KB, patch)
2012-01-19 17:58 PST, Daniel Sievers 		no flags
DetailsFormatted DiffDiff
Patch (2.73 KB, patch)
2012-01-20 11:31 PST, Daniel Sievers 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Daniel Sievers
Comment 1 2012-01-19 17:56:19 PST
Created attachment 123229 [details] Patch
Daniel Sievers
Comment 2 2012-01-19 17:58:53 PST
Created attachment 123230 [details] Patch
WebKit Review Bot
Comment 3 2012-01-19 18:02:06 PST
Attachment 123229 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1 Source/WebKit/chromium/ChangeLog:7: Line contains tab character. [whitespace/tab] [5] Source/WebKit/chromium/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Source/WebKit/chromium/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] Source/WebKit/chromium/ChangeLog:11: Line contains tab character. [whitespace/tab] [5] Total errors found: 4 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
James Robinson
Comment 4 2012-01-19 18:11:28 PST
Comment on attachment 123230 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123230&action=review > Source/WebKit/chromium/src/WebViewImpl.cpp:2979 > + bool visible = false; > + if (m_page && m_page->visibilityState() == PageVisibilityStateVisible) > + visible = true; this looks unnecessarily verbose - why not initialize on the same line you declare?
Daniel Sievers
Comment 5 2012-01-20 11:31:07 PST
Created attachment 123348 [details] Patch
James Robinson
Comment 6 2012-01-20 11:46:09 PST
Comment on attachment 123348 [details] Patch R=me
Note You need to log in before you can comment on or make changes to this bug.