Bug 76671

Summary: Some qmake build files must include Qt5's "quick" module.
Product: WebKit Reporter: Marcelo Lira <marcelo.lira>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: cshu, hausmann, kenneth, vestbo, webkit.review.bot, yael, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch hausmann: review-

Description Marcelo Lira 2012-01-19 15:38:23 PST
Some qmake build files must include Qt5's "quick" module.
Comment 1 Marcelo Lira 2012-01-19 15:52:40 PST
Created attachment 123215 [details]
Comment 2 Simon Hausmann 2012-01-20 05:44:51 PST
Comment on attachment 123215 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=123215&action=review

Why do they _must

> Source/WTF/ChangeLog:3
> +        Some qmake build files must include Qt5's "quick" module.

Why _must_?

I know that qmake spits out a _warning_ currently, but that warning is harmless AFAICS. We should only add libQtQuick as a dependency where we _really_ need it, and AFAIK that has been done already.
Comment 3 Tor Arne Vestbø 2012-01-20 06:05:13 PST
We should add CONFIG option to Qt to allow us to silence this message if we know what we are doing.
Comment 4 Marcelo Lira 2012-01-20 06:21:11 PST
Perhaps "must" was too strong a word, "should" would be better.
The thing is that in Qt5 the "quick" module was taken out from the "declarative" module. Previous uses of Declarative expect Quick to be there too when declaring "declarative" in the build files, but now it must be explicitly stated.
Comment 5 Simon Hausmann 2012-01-24 03:14:33 PST
The change in http://codereview.qt-project.org/#change,13637 corrected the "false" warning in Qt.
Comment 6 Simon Hausmann 2012-01-24 03:18:45 PST
Comment on attachment 123215 [details]

I did a fresh build, only tests.pri, api.pri, MiniBrowser and WTR need QT += quick. I'll land that as build fix, because we need it for the next qt5 update.
Comment 7 Simon Hausmann 2012-01-24 03:22:57 PST
Committed r105719: <http://trac.webkit.org/changeset/105719>
Comment 8 Yael 2012-01-25 06:01:37 PST
Some of this is still needed if you build with the flag force_static_libs_as_shared .
Comment 9 Yael 2012-01-31 19:05:58 PST
Fixed with http://trac.webkit.org/changeset/105990.
Closing the bug.