Bug 76637

Summary: Update FloatRect::uniteIfNonZero to use isZero()
Product: WebKit Reporter: Philip Rogers <pdr>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, darin, leviw, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Update uniteIfNonZero to use isZero
none
Update uniteIfNonZero to use isZero
none
Update uniteIfNonZero to use isZero none

Description Philip Rogers 2012-01-19 08:13:04 PST
We should update uniteIfNonZero() to use isZero() instead of a !width() && !height().

See: https://bugs.webkit.org/show_bug.cgi?id=76177#c3
Comment 1 Philip Rogers 2012-01-19 08:15:47 PST
Created attachment 123133 [details]
Update uniteIfNonZero to use isZero
Comment 2 Philip Rogers 2012-01-19 08:36:07 PST
Created attachment 123135 [details]
Update uniteIfNonZero to use isZero

A note on why I added no tests: I did a little research on what this change will affect and I came up empty handed. I instrumented the code and ran all our tests and visited various popular/complex pages, neither of which registered a difference between the old behavior and the new. The primary use of uniteIfNonZero in regular code is in RenderInline.cpp which, as far as I can tell in my testing, only passes integer values through to this method and should not be affected by this change. I still think this is change will be clearly useful in preventing future bugs.
Comment 3 Alexey Proskuryakov 2012-01-19 12:09:01 PST
Comment on attachment 123135 [details]
Update uniteIfNonZero to use isZero

View in context: https://bugs.webkit.org/attachment.cgi?id=123135&action=review

> Source/WebCore/ChangeLog:15
> +        * rendering/svg/SVGRenderSupport.cpp:
> +        (WebCore::SVGRenderSupport::computeContainerBoundingBoxes):

It would be helpful to explain this change in ChangeLog. Readers needn't spend effort trying to figure out how it's related to bug title when it's not!
Comment 4 Philip Rogers 2012-01-19 12:22:01 PST
Created attachment 123171 [details]
Update uniteIfNonZero to use isZero

Adding a comment in the ChangeLog so that readers are not confused by the unrelated change in SVGRenderSupport.cpp.
Comment 5 Darin Adler 2012-01-23 10:43:48 PST
Comment on attachment 123171 [details]
Update uniteIfNonZero to use isZero

OK
Comment 6 WebKit Review Bot 2012-01-23 14:38:09 PST
Comment on attachment 123171 [details]
Update uniteIfNonZero to use isZero

Clearing flags on attachment: 123171

Committed r105643: <http://trac.webkit.org/changeset/105643>
Comment 7 WebKit Review Bot 2012-01-23 14:38:13 PST
All reviewed patches have been landed.  Closing bug.