Bug 76629 – new baselines for crbug 110493

• Component: Tools / Tests
• Status: RESOLVED FIXED

new baselines for crbug 110493

created using steps at https://goto.google.com/HowToRebaselineWebkitTests

Created attachment 123122 [details]
Patch

Mike- please review the image diffs at http://www.corp.google.com/~epoger/rebaselines/2012-01-19-06-58-00/rebaseline.html

Dirk- please r+ if you approve the rebaseline

[Mike Reed]

purty
+1

[WebKit Review Bot]

Comment on attachment 123122 [details]
Patch

Attachment 123122 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11300102

New failing tests:
svg/transforms/animated-path-inside-transformed-html.xhtml
svg/custom/focus-ring.svg
fast/backgrounds/repeat/negative-offset-repeat-transformed.html
fast/borders/border-image-rotate-transform.html

Uh-oh, I don't like those layout test failures in chromium-ews.

I guess the problem is that http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/DEPS is still pulling Chrome rev 117882 , while the Chrome change that necessitates these rebaselines didn't land until http://crrev.com/118095 .

So I guess I need to wait until the next Webkit-Chrome deps roll before doing this?  Mike/Dirk, does that sound right?

[Dirk Pranke]

Comment on attachment 123122 [details]
Patch

Hm. It is kinda hard to review this w/o the old baselines :). I'll take your word for it that they're right.

It's easy enough to roll the chromium deps on the webkit bots; I can do that if you like (if someone else hasn't already) and then we can re-run the EWS bots.

(In reply to comment #6)
> (From update of attachment 123122 [details])
> Hm. It is kinda hard to review this w/o the old baselines :). I'll take your word for it that they're right.

If you are on the Google corp network, you can view my nicer diffs at http://www.corp.google.com/~epoger/rebaselines/2012-01-19-06-58-00/rebaseline.html .  At any rate, Mike looked at those and is comfortable with the changes.

> 
> It's easy enough to roll the chromium deps on the webkit bots; I can do that if you like (if someone else hasn't already) and then we can re-run the EWS bots.

If you could roll those for me, that would be great.  Thanks for offering.  (I am reluctant to do a roll like that myself, because then I "own" whatever other problems come along for the ride!!!)

[Dirk Pranke]

Rolled to r118291. If you re-upload the patch, it'll re-run the EWS bots (there's no other way to do that, unfortunately).

Created attachment 123177 [details]
Patch

Thanks, Dirk!  Can you please r+ again, and then I will commit later ONCE THE EWS BOTS COMPLETE SUCCESSFULLY...

[WebKit Review Bot]

Comment on attachment 123177 [details]
Patch

Clearing flags on attachment: 123177

Committed r105510: <http://trac.webkit.org/changeset/105510>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.