Summary: | Cache and reuse the NodeList returned by Node::childNodes(). | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||
Component: | DOM | Assignee: | Andreas Kling <kling> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | rboucher | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Andreas Kling
2012-01-18 17:44:31 PST
Created attachment 123048 [details]
Patch
Comment on attachment 123048 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123048&action=review Could you clarify that new behavior matches FF/Opera as discussed on IRC? > Source/WebCore/dom/ChildNodeList.h:44 > + void reset() { m_caches->reset(); } We should move m_caches to DynamicNodList. Once we do that, we can just call DyanmicNodeList::invalidateCache instead. Comment on attachment 123048 [details]
Patch
kling says he'll do the m_caches move in a follow up. r=me provided the change log entry is updated to mention the improved compatibility with other browsers.
Committed r105372: <http://trac.webkit.org/changeset/105372> |