Bug 76580 – [chromium] Layout Test media/media-document-audio-repaint.html is flaky

• Component: Tools / Tests
• Status: RESOLVED FIXED

[James Robinson]

The following layout test is flaky on chromium:

media/media-document-audio-repaint.html


In webkit_tests looks flaky on chromium mac debug:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=media%2Fmedia-document-audio-repaint.html

In webkit_gpu_tests looks the most flaky on linux:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20GPU%20Mesa%20-%20chromium.org&tests=media%2Fmedia-document-audio-repaint.html

[Ami Fischman]

I bet this is fallout from http://crrev.com/116702 after which we don't have GPU compositing turned on for audio-only mediadocuments.

@imasaki: can you rebaseline?

[Ami Fischman]

Created attachment 126863 [details]
Patch

[Ami Fischman]

JamesR: does this look right to you?

(I realized my comment #1 is wrong; rebaselining isn't enough b/c different runs produce different output; I believe the reason is that the lTC.display() call is being made at an underspecified point).

[Ami Fischman]

Comment on attachment 126863 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126863&action=review

> LayoutTests/media/media-document-audio-repaint.html:19
>          }, 100)

Umm, hold off reviewing.  This is craxy.

[James Robinson]

Comment on attachment 126863 [details]
Patch

Try taking a look at fast/repaint/resources/repaint.js

[Ami Fischman]

Created attachment 126906 [details]
Patch

[James Robinson]

Comment on attachment 126906 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126906&action=review

R=me except for an errant character in the test

> LayoutTests/media/media-document-audio-repaint.html:21
> +        var videoElement = document.getElementById("fr").contentDocument.querySelector("video");w

trailing 'w' on this line. i'm guessing your editor is vim?

[Ami Fischman]

Created attachment 126986 [details]
Patch

[Ami Fischman]

> R=me except for an errant character in the test

webkit etiquette q: do I wait for another r+ from you on the updated patch in this sort of situation, or do I commit on the strength of your previous r+?

> > LayoutTests/media/media-document-audio-repaint.html:21
> > +        var videoElement = document.getElementById("fr").contentDocument.querySelector("video");w
> 
> trailing 'w' on this line. 

Gone.

> i'm guessing your editor is vim?

Nope, making this even stranger :)

[WebKit Review Bot]

Attachment 126986 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9

Updating OpenSource
First, rewinding head to replay your work on top of it...
Applying: [Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets
Using index info to reconstruct a base tree...
<stdin>:1578: trailing whitespace.
        
<stdin>:1647: trailing whitespace.
    
<stdin>:1657: trailing whitespace.
    
<stdin>:1672: trailing whitespace.
        return 0;        
<stdin>:1674: trailing whitespace.
    
warning: squelched 7 whitespace errors
warning: 12 lines add whitespace errors.
Falling back to patching base and 3-way merge...
warning: too many files (created: 168776 deleted: 3), skipping inexact rename detection
Auto-merging LayoutTests/ChangeLog
Auto-merging Source/WebCore/ChangeLog
CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog
Auto-merging Source/WebKit2/ChangeLog
CONFLICT (content): Merge conflict in Source/WebKit2/ChangeLog
Auto-merging Tools/ChangeLog
CONFLICT (content): Merge conflict in Tools/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 [Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.


If any of these errors are false positives, please file a bug against check-webkit-style.

[Ami Fischman]

(note style bot borkage is unrelated to this patch)

[James Robinson]

(In reply to comment #9)
> > R=me except for an errant character in the test
> 
> webkit etiquette q: do I wait for another r+ from you on the updated patch in this sort of situation, or do I commit on the strength of your previous r+?
> 

WebKit etiquette is that a r+ cq- with minor comments means that the reviewer is fine with you landing the patch without going another review round.  webkit-patch land-safely makes this pretty easy if you still want to use the commit queue.

[WebKit Review Bot]

Comment on attachment 126986 [details]
Patch

Clearing flags on attachment: 126986

Committed r107721: <http://trac.webkit.org/changeset/107721>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.