Bug 76565

Summary: Save two ID checks on CSS property validation
Product: WebKit Reporter: Thiago Marcos P. Santos <tmpsantos>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: kling, macpherson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Fixes double check on property validation none

Thiago Marcos P. Santos
Reported 2012-01-18 13:27:47 PST
The same validation is done again in the next case statement. Check for CSSValueIntrinsic and CSSValueMinIntrinsic was done twice when the value is a number.
Attachments
Fixes double check on property validation (1.42 KB, patch)
2012-01-18 13:34 PST, Thiago Marcos P. Santos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Thiago Marcos P. Santos
Comment 1 2012-01-18 13:34:49 PST
Created attachment 122983 [details] Fixes double check on property validation
Andreas Kling
Comment 2 2012-01-18 15:26:17 PST
Comment on attachment 122983 [details] Fixes double check on property validation r=me
WebKit Review Bot
Comment 3 2012-01-18 18:02:18 PST
Comment on attachment 122983 [details] Fixes double check on property validation Clearing flags on attachment: 122983 Committed r105370: <http://trac.webkit.org/changeset/105370>
WebKit Review Bot
Comment 4 2012-01-18 18:02:22 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.