Bug 76560

Summary: Need a WebKit2 API for setting media volume
Product: WebKit Reporter: Ada Chan <adachan>
Component: WebKit2Assignee: Ada Chan <adachan>
Status: RESOLVED FIXED    
Severity: Normal CC: mitz
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
mitz: review-
Take 2: Make sure WebPageProxy caches the media volume value.
none
Take 3 mitz: review+

Ada Chan
Reported 2012-01-18 12:06:02 PST
Add a WebKit2 API for setting media volume in a page. Needed for <rdar://problem/10619329>
Attachments
Patch (6.21 KB, patch)
2012-01-18 12:18 PST, Ada Chan 		mitz: review-
DetailsFormatted DiffDiff
Take 2: Make sure WebPageProxy caches the media volume value. (9.65 KB, patch)
2012-01-18 15:50 PST, Ada Chan 		no flags
DetailsFormatted DiffDiff
Take 3 (10.21 KB, patch)
2012-01-18 17:50 PST, Ada Chan 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ada Chan
Comment 1 2012-01-18 12:18:10 PST
Created attachment 122974 [details] Patch
mitz
Comment 2 2012-01-18 13:34:45 PST
Comment on attachment 122974 [details] Patch Like most settings on WKPage, this setting needs to persist even if the Web process crashes and gets relaunched. This means that you need to cache it in a member variable in WebPagePorxy, and add it to WebPageCreationParameters and to WebPageProxy::creationParameters() and the WebPage constructor. Having the value cached in the WebPageProxy would also make it easy to add a getter on WKPage in addition to the setter you’ve added.
Ada Chan
Comment 3 2012-01-18 14:45:46 PST
(In reply to comment #2) > (From update of attachment 122974 [details]) > Like most settings on WKPage, this setting needs to persist even if the Web process crashes and gets relaunched. This means that you need to cache it in a member variable in WebPagePorxy, and add it to WebPageCreationParameters and to WebPageProxy::creationParameters() and the WebPage constructor. Having the value cached in the WebPageProxy would also make it easy to add a getter on WKPage in addition to the setter you’ve added. Thanks for the review! I'll make the changes you suggested.
Ada Chan
Comment 4 2012-01-18 15:50:27 PST
Created attachment 123026 [details] Take 2: Make sure WebPageProxy caches the media volume value.
Ada Chan
Comment 5 2012-01-18 17:50:15 PST
Created attachment 123044 [details] Take 3 Two more fixes: - Need to set the media volume with value from WebPageCreationParameters in WebPage::WebPage(). - Need to set WebPageProxy::m_mediaVolume even if the associated WebPage is no longer valid in the web process, since that updated value should be used when the web process is relaunched.
Ada Chan
Comment 6 2012-01-19 13:34:32 PST
Committed: http://trac.webkit.org/changeset/105439
Note You need to log in before you can comment on or make changes to this bug.