Summary: | [Skia Mac] Match style of platform error underline for misspellings | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Cary Clark <caryclark> | ||||||
Component: | New Bugs | Assignee: | Cary Clark <caryclark> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | senorblanco, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Cary Clark
2012-01-18 11:09:19 PST
Created attachment 122968 [details]
Patch
this is chromium bug 110009 Comment on attachment 122968 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122968&action=review Looks good, assuming it passes the linter. r=me > Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp:659 > +#if PLATFORM(CHROMIUM) && OS(DARWIN) Nit: Probably don't need PLATFORM(CHROMIUM) here, but I see you've added it elsewhere. Comment on attachment 122968 [details] Patch Rejecting attachment 122968 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: cceeded at 1 with fuzz 3. patching file Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/chromium/test_expectations.txt Hunk #1 FAILED at 3901. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Stephen White', u'--fo..." exit_code: 1 Full output: http://queues.webkit.org/results/11132184 Created attachment 123188 [details]
Patch
First patch ran into an overlapping change in test_expectations.txt. Other than resolving the conflict, the patch is identical to the one uploaded before. Comment on attachment 123188 [details]
Patch
OK. r=me
Comment on attachment 123188 [details] Patch Clearing flags on attachment: 123188 Committed r105468: <http://trac.webkit.org/changeset/105468> All reviewed patches have been landed. Closing bug. Committed r109588: <http://trac.webkit.org/changeset/109588> |