Bug 76556

Summary: [Skia Mac] Match style of platform error underline for misspellings
Product: WebKit Reporter: Cary Clark <caryclark>
Component: New BugsAssignee: Cary Clark <caryclark>
Severity: Normal CC: senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch none

Description Cary Clark 2012-01-18 11:09:19 PST
[Skia Mac] Match style of platform error underline for misspellings
Comment 1 Cary Clark 2012-01-18 11:15:15 PST
Created attachment 122968 [details]
Comment 2 Cary Clark 2012-01-18 11:17:01 PST
this is chromium bug 110009
Comment 3 Stephen White 2012-01-19 12:04:56 PST
Comment on attachment 122968 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=122968&action=review

Looks good, assuming it passes the linter.  r=me

> Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp:659

Nit:  Probably don't need PLATFORM(CHROMIUM) here, but I see you've added it elsewhere.
Comment 4 WebKit Review Bot 2012-01-19 12:48:47 PST
Comment on attachment 122968 [details]

Rejecting attachment 122968 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
cceeded at 1 with fuzz 3.
patching file Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/chromium/test_expectations.txt
Hunk #1 FAILED at 3901.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Stephen White', u'--fo..." exit_code: 1

Full output: http://queues.webkit.org/results/11132184
Comment 5 Cary Clark 2012-01-19 13:52:31 PST
Created attachment 123188 [details]
Comment 6 Cary Clark 2012-01-19 13:53:30 PST
First patch ran into an overlapping change in test_expectations.txt. Other than resolving the conflict, the patch is identical to the one uploaded before.
Comment 7 Stephen White 2012-01-19 14:16:07 PST
Comment on attachment 123188 [details]

OK.   r=me
Comment 8 WebKit Review Bot 2012-01-19 17:47:56 PST
Comment on attachment 123188 [details]

Clearing flags on attachment: 123188

Committed r105468: <http://trac.webkit.org/changeset/105468>
Comment 9 WebKit Review Bot 2012-01-19 17:48:01 PST
All reviewed patches have been landed.  Closing bug.
Comment 10 Cary Clark 2012-03-02 11:29:22 PST
Committed r109588: <http://trac.webkit.org/changeset/109588>