Lazy init for DefaultAudioDestinationNode?

• Component: Web Audio
• Status: RESOLVED FIXED

[Raymond]

Hi


In AudioContext's lazyInitialize m_destinationNode->initialize() is called, so is it necessary to call initialize in DefaultAudioDestinationNode's constructor? Will that help the lazyInitialize conception by not call it in DefaultAudioDestinationNode's constructor?

If so, I will be glad to provide this one line patch ;)

[Chris Rogers]

Sure, sounds reasonable to me.  I had a quick look through the code and couldn't see any obvious problems.  It would be good if you could quickly test your change on a couple of the web audio demos just as a sanity check.

[Raymond]

Created attachment 123427 [details]
Patch

[Raymond]

Well, it's not that simple as I thought before. The sampleRate() function is called in the AudioContext constructor, which required the m_destination to be available.

While, I think that sampleRate() function is already provided by AudioNode, so why not just use it, after all , the current AudioDestination implementation just return the same sampleRate passed in during construction. Thus AudioDestinationNode and AudioDestination share the same sampleRate. And if later we need to dynamic adjust sampleRate, we might set sample rate from AudioDestination to AudioDestinationNode.

Anyway, the result is the patch attached

[Raymond]

Comment on attachment 123427 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123427&action=review

> Source/WebCore/webaudio/DefaultAudioDestinationNode.cpp:-38
> -    initialize();

I also considered to move this empty one to head file, but then I think again, due to it is a private function, and who knows we might add something here later. So I choose to leave it here.

[Eric Seidel (no email)]

Comment on attachment 123427 [details]
Patch

If Chris is OK with this then r=me.

[Chris Rogers]

Looks good.

[WebKit Review Bot]

Comment on attachment 123427 [details]
Patch

Clearing flags on attachment: 123427

Committed r108022: <http://trac.webkit.org/changeset/108022>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.