Bug 76498

Summary: [chromium] Apply color profiles in more cases
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: jbauman, noel.gordon, senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 75999    
Bug Blocks: 82428    
Attachments:
Description Flags
Patch none

Description Kenneth Russell 2012-01-17 17:03:17 PST 
The fix for Bug 75999 disabled the application of color profiles whenever WebGL's premultipliedAlpha flag is set. We can do better than this if we check to see whether the image has an alpha channel before deciding not to apply the color profile.
Comment 1 Kenneth Russell 2012-01-17 17:10:45 PST 
Created attachment 122843 [details]
Patch
Comment 2 Stephen White 2012-01-17 17:30:31 PST 
Comment on attachment 122843 [details]
Patch

I'm not very familiar with this code, but I'll trust the test results.  r=me
Comment 3 noel gordon 2012-01-17 17:43:47 PST 
LGTM.
Comment 4 WebKit Review Bot 2012-01-17 19:09:33 PST 
Comment on attachment 122843 [details]
Patch

Clearing flags on attachment: 122843

Committed r105230: <http://trac.webkit.org/changeset/105230>
Comment 5 WebKit Review Bot 2012-01-17 19:09:37 PST 
All reviewed patches have been landed.  Closing bug.