Bug 76496

Summary:

file:// doesn't work as base URL

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Platform

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

76563, 76619, 76631, 76653

Bug Blocks:

Attachments:

Description	Flags
proposed patch	darin: review+

Alexey Proskuryakov

Reported 2012-01-17 16:58:18 PST

KURL normalizes "file://" to "file:". When later used as a base URL, it's seen as a non-hierarchical one, making completion fail. This works fine in both IE and Firefox, as the URL is canonicalized to "file:///".

Attachments
proposed patch (8.13 KB, patch) 2012-01-17 17:26 PST, Alexey Proskuryakov	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2012-01-17 17:26:56 PST

Created attachment 122847 [details] proposed patch

Alexey Proskuryakov

Comment 2 2012-01-18 10:42:17 PST

Committed <http://trac.webkit.org/changeset/105294>.

Csaba Osztrogonác

Comment 3 2012-01-18 11:52:47 PST

Reopen, because it broke tests: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20%28Tests%29/r105294%20%2836456%29/results.html http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20%28Tests%29/r105294%20%2836456%29/http/tests/misc/bubble-drag-events-pretty-diff.html http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r105294%20(32592)/fast/loader/url-parse-1-pretty-diff.html http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r105294%20(32592)/http/tests/misc/iframe-invalid-source-crash-pretty-diff.html Could you check and fix them?

Alexey Proskuryakov

Comment 4 2012-01-18 12:12:39 PST

Looking. Strange, I updated results of two of these.

Alexey Proskuryakov

Comment 5 2012-01-18 12:20:36 PST

Thank you - update results in <http://trac.webkit.org/changeset/105307>. However, iframe-invalid-source-crash.html and bubble-drag-events.html appear to be broken on Qt because of a DumpRenderTree difference, where it dumps "file:///" as empty path instead of "/". I'll file a separate bug for this.

Note You need to log in before you can comment on or make changes to this bug.