Bug 76470

Summary: HRTFPanner could have high-quality mode for smoother transitions
Product: WebKit Reporter: Chris Rogers <crogers>
Component: Web AudioAssignee: Chris Rogers <crogers>
Status: RESOLVED FIXED    
Severity: Normal CC: crogers, dglazkov, kbr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch kbr: review+

Chris Rogers
Reported 2012-01-17 12:07:32 PST
The HRTFPanner works reasonably well, but can have "zipper" artifacts when panning some source material. Interpolation between different panning positions can help this somewhat, with some added performance cost.
Attachments
Patch (15.53 KB, patch)
2012-01-27 15:59 PST, Chris Rogers 		no flags
DetailsFormatted DiffDiff
Patch (15.81 KB, patch)
2012-01-27 17:43 PST, Chris Rogers 		kbr: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Rogers
Comment 1 2012-01-27 15:59:38 PST
Created attachment 124389 [details] Patch
Kenneth Russell
Comment 2 2012-01-27 16:08:12 PST
Comment on attachment 124389 [details] Patch Could you fix the Mac build failure?
WebKit Review Bot
Comment 3 2012-01-27 16:23:10 PST
Comment on attachment 124389 [details] Patch Attachment 124389 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11349896
Chris Rogers
Comment 4 2012-01-27 17:43:59 PST
Created attachment 124409 [details] Patch
Chris Rogers
Comment 5 2012-01-27 17:44:41 PST
removed wrapDistance() to try to fix build errors.
Kenneth Russell
Comment 6 2012-01-27 17:50:47 PST
Comment on attachment 124409 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124409&action=review Looks fine overall; a few minor nits which you can fix upon landing. r=me > Source/WebCore/platform/audio/HRTFPanner.cpp:47 > +const int UnitializedAzimuth = -1; Typo: should be Uninitialized. > Source/WebCore/platform/audio/HRTFPanner.cpp:65 > + , m_tempL1(128) Please define and use a constant instead of the value 128. Could use it below too. > Source/WebCore/platform/audio/HRTFPanner.cpp:287 > + if (m_crossfadeIncr < 0 && fabs(m_crossfadeX) < -m_crossfadeIncr) { Could use an else if here.
Chris Rogers
Comment 7 2012-01-27 18:16:31 PST
Committed r106173: <http://trac.webkit.org/changeset/106173>
Note You need to log in before you can comment on or make changes to this bug.