Summary: | Crash when typing into text contols | ||
---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
Component: | Forms | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Critical | CC: | adele, justin.garcia, sullivan |
Priority: | P1 | Keywords: | Regression |
Version: | 420+ | ||
Hardware: | Mac | ||
OS: | OS X 10.4 |
Description
Eric Seidel (no email)
2006-03-07 13:07:08 PST
The assertion that's failing is in Safari, not WebKit. However, if this just started happening then it must be triggered by some recent WebCore/WebKit change, since this Safari code has not changed recently. Eric, did this just started happening recently? Does it happen on every page with a text field, including Google? I can't reproduce a problem either on Google or on this bugzilla page (I tried typing into the Keywords field). I have tip of tree Safari, but not quite tip of tree WebCore/WebKit at the moment. This is a form control issue, not an HTML Editing issue (changing component). I've now built tip of tree WebCore/WebKit/Safari, and I cannot reproduce this problem in the text field at http://www.google.com. I see from Eric's backtrace that the assertion that's failing is: ASSERT([element _isTextField]); The method -[DOMHTMLInputElement _isTextField] is implemented in DOMHTML.mm in WebCore. It checks the type of an input element against the list of types that represent text fields. So either the element is nil, or there's some funky unexpected type set on this element. Maybe Eric is seeing this instead of me because he's testing Adele's new NSView-less text field code somehow? I'm happy to help clarify this further, but I still don't know how to reproduce. This change from Darin's checkin yesterday is probably the cause. I can repro. (-[WebCoreFrameBridge elementForView:]): Changed KWQWidgetHolder to WebCoreWidgetHolder. I'll look into this. This check is failing... if ([view conformsToProtocol:@protocol(WebCoreWidgetHolder)]) |