Bug 76441

Summary: [Chromium] Cleanup of WebPopupMenuImpl
Product: WebKit Reporter: Kent Tamura <tkent>
Component: WebKit Misc.Assignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Minor CC: haraken, morrita, webkit.review.bot
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch 3 none

Kent Tamura
Reported 2012-01-17 02:12:41 PST
[Chromium] Cleanup of WebPopupMenuImpl
Attachments
Patch (19.49 KB, patch)
2012-01-17 02:30 PST, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch (19.49 KB, patch)
2012-01-17 02:33 PST, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch 3 (19.47 KB, patch)
2012-01-26 18:32 PST, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2012-01-17 02:30:56 PST
Created attachment 122740 [details] Patch
Kent Tamura
Comment 2 2012-01-17 02:33:44 PST
Created attachment 122741 [details] Patch
Kentaro Hara
Comment 3 2012-01-26 08:40:59 PST
Comment on attachment 122741 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122741&action=review > Source/WebKit/chromium/src/WebPopupMenuImpl.cpp:169 > + deref(); // Balances ref() from WebWidget::Create. Where is WebWidget::Create? I couldn't find it. > Source/WebKit/chromium/src/WebPopupMenuImpl.cpp:229 > + // FIXME: WebKit seems to always return false on mouse events methods. For FIXME (jcampan)?
Kent Tamura
Comment 4 2012-01-26 18:30:41 PST
Comment on attachment 122741 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122741&action=review >> Source/WebKit/chromium/src/WebPopupMenuImpl.cpp:169 >> + deref(); // Balances ref() from WebWidget::Create. > > Where is WebWidget::Create? I couldn't find it. Good catch! It should be WebPopupMenu::create. >> Source/WebKit/chromium/src/WebPopupMenuImpl.cpp:229 >> + // FIXME: WebKit seems to always return false on mouse events methods. For > > FIXME (jcampan)? Our style is FIXME without a name. http://www.webkit.org/coding/coding-style.html#comments-fixme
Kent Tamura
Comment 5 2012-01-26 18:32:09 PST
Created attachment 124232 [details] Patch 3
Kent Tamura
Comment 6 2012-01-26 19:00:28 PST
Comment on attachment 124232 [details] Patch 3 Thanks!
WebKit Review Bot
Comment 7 2012-01-26 20:48:41 PST
Comment on attachment 124232 [details] Patch 3 Clearing flags on attachment: 124232 Committed r106084: <http://trac.webkit.org/changeset/106084>
WebKit Review Bot
Comment 8 2012-01-26 20:48:46 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.