| Summary: | [Chromium] Cleanup of WebPopupMenuImpl | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kent Tamura <tkent> | ||||||||
| Component: | WebKit Misc. | Assignee: | Kent Tamura <tkent> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Minor | CC: | haraken, morrita, webkit.review.bot | ||||||||
| Priority: | P3 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Other | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Kent Tamura
2012-01-17 02:12:41 PST
Created attachment 122740 [details]
Patch
Created attachment 122741 [details]
Patch
Comment on attachment 122741 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122741&action=review > Source/WebKit/chromium/src/WebPopupMenuImpl.cpp:169 > + deref(); // Balances ref() from WebWidget::Create. Where is WebWidget::Create? I couldn't find it. > Source/WebKit/chromium/src/WebPopupMenuImpl.cpp:229 > + // FIXME: WebKit seems to always return false on mouse events methods. For FIXME (jcampan)? Comment on attachment 122741 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122741&action=review >> Source/WebKit/chromium/src/WebPopupMenuImpl.cpp:169 >> + deref(); // Balances ref() from WebWidget::Create. > > Where is WebWidget::Create? I couldn't find it. Good catch! It should be WebPopupMenu::create. >> Source/WebKit/chromium/src/WebPopupMenuImpl.cpp:229 >> + // FIXME: WebKit seems to always return false on mouse events methods. For > > FIXME (jcampan)? Our style is FIXME without a name. http://www.webkit.org/coding/coding-style.html#comments-fixme Created attachment 124232 [details]
Patch 3
Comment on attachment 124232 [details]
Patch 3
Thanks!
Comment on attachment 124232 [details] Patch 3 Clearing flags on attachment: 124232 Committed r106084: <http://trac.webkit.org/changeset/106084> All reviewed patches have been landed. Closing bug. |