Summary: | AssociatedURLLoader doesn't support Access-Control-Expose-Header field in response. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Bill Budge <bbudge> | ||||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Bill Budge
2012-01-16 19:20:07 PST
Created attachment 122704 [details]
Proposed Patch
Attachment 122704 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1
Source/WebKit/chromium/tests/AssociatedURLLoaderTest.cpp:43: wtf includes should be <wtf/file.h> instead of "wtf/file.h". [build/include] [4]
Source/WebKit/chromium/src/AssociatedURLLoader.cpp:107: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 2 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 122713 [details]
Proposed Patch
Comment on attachment 122713 [details]
Proposed Patch
It's unfortunate that we need to duplicate this logic from XMLHttpRequest. It feels like we're missing some common piece of infrastructure that the two could shard.
Comment on attachment 122713 [details] Proposed Patch Clearing flags on attachment: 122713 Committed r105134: <http://trac.webkit.org/changeset/105134> All reviewed patches have been landed. Closing bug. |