Bug 76384

Summary:

Web Inspector: setCurrentFocusElement should not update selection when focus is moved to text field or text area.

Product:

WebKit

Reporter:

Vsevolod Vlasov <vsevik>

Component:

Web Inspector (Deprecated)

Assignee:

Vsevolod Vlasov <vsevik>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys, zimmermann

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Final patch chunk, v1	none

Vsevolod Vlasov

Reported 2012-01-16 08:19:12 PST

setCurrentFocusElement should not update selection when focus is moved to text field or text area. In these cases focus is correctly updated automatically.

Attachments
Patch (3.70 KB, patch) 2012-01-16 08:26 PST, Vsevolod Vlasov	no flags	Details Formatted Diff Diff
Final patch chunk, v1 (713.98 KB, patch) 2012-01-16 08:54 PST, Nikolas Zimmermann	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Vsevolod Vlasov

Comment 1 2012-01-16 08:26:04 PST

Created attachment 122643 [details] Patch

Timothy Hatcher

Comment 2 2012-01-16 08:31:51 PST

Comment on attachment 122643 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122643&action=review > Source/WebCore/inspector/front-end/UIUtils.js:597 > + const textInputTypes = ["text", "search", "tel", "url", "email", "password"]; > + if (element instanceof HTMLInputElement) > + return textInputTypes.indexOf(element.type) !== -1; A faster way to do this would be: outside function: WebInspector._textInputTypes = ["text", "search", "tel", "url", "email", "password"].keySet(); inside function: if (element instanceof HTMLInputElement) return element.type in WebInspector._textInputTypes;

Vsevolod Vlasov

Comment 3 2012-01-16 08:47:40 PST

Committed r105066: <http://trac.webkit.org/changeset/105066>

Nikolas Zimmermann

Comment 4 2012-01-16 08:54:47 PST

Reopening to attach new patch.

Nikolas Zimmermann

Comment 5 2012-01-16 08:54:59 PST

Created attachment 122646 [details] Final patch chunk, v1

Nikolas Zimmermann

Comment 6 2012-01-16 08:56:44 PST

Comment on attachment 122646 [details] Final patch chunk, v1 Oops, webkit-patch got confused, it uploaded the patch to the wrong br. Please ignore this.

Vsevolod Vlasov

Comment 7 2012-01-16 08:57:53 PST

Marking as fixed again.

Note You need to log in before you can comment on or make changes to this bug.