Summary: | [Blackberry] Non-supported about: operations never stops loading | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris.Guan <logingx> | ||||||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | logingx, rwlbuis, staikos, tonikitoo, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 73144 | ||||||||||
Attachments: |
|
Description
Chris.Guan
2012-01-15 22:27:45 PST
Created attachment 125554 [details]
Patch
Created attachment 125556 [details]
Patch
Comment on attachment 125556 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125556&action=review you amended wrongly :-) > Source/WebCore/ChangeLog:8 > + If user typed the non-supported "about:" scheme such as "about:nonsupport", nit: s/the/a > Source/WebCore/ChangeLog:9 > + loadAboutURL() fucntion in NetworkManger should recognize and handle typo: function* > Source/WebCore/ChangeLog:33 > +2012-02-05 Andreas Kling <awesomekling@apple.com> > + > + Remove unused file MappedAttributeEntry.h. > + <http://webkit.org/b/77841> > + > + Reviewed by Anders Carlsson. > + > + * GNUmakefile.list.am: > + * WebCore.gypi: > + * WebCore.vcproj/WebCore.vcproj: > + * WebCore.xcodeproj/project.pbxproj: > + * dom/MappedAttributeEntry.h: Removed. > + * dom/StyledElement.h: > + this should not be here :-) Created attachment 125562 [details]
Patch
Comment on attachment 125562 [details]
Patch
It looks ok to me...
maybe our DRT support testing this, Rob?
(In reply to comment #5) > (From update of attachment 125562 [details]) > It looks ok to me... > > maybe our DRT support testing this, Rob? Thanks, Antonio, do you want DRT to run all schemata such as "data: about: credits: cache: config: ..."? (In reply to comment #6) > (In reply to comment #5) > > (From update of attachment 125562 [details] [details]) > > It looks ok to me... > > > > maybe our DRT support testing this, Rob? > > Thanks, Antonio, do you want DRT to run all schemata such as "data: about: credits: cache: config: ..."? hum, not sure. I would actually like to ensure that any other schemas other than the supported ones load as expected: error page :) (In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #5) > > > (From update of attachment 125562 [details] [details] [details]) > > > It looks ok to me... > > > > > > maybe our DRT support testing this, Rob? > > > > Thanks, Antonio, do you want DRT to run all schemata such as "data: about: credits: cache: config: ..."? > > hum, not sure. I would actually like to ensure that any other schemas other than the supported ones load as expected: error page :) yes, an invalide url err page will be shown up if that schema is not supported by us:) (In reply to comment #5) > (From update of attachment 125562 [details]) > It looks ok to me... > > maybe our DRT support testing this, Rob? The code looks fine to me too. I'll check whether DRT supports about: Cheers, Rob. (In reply to comment #9) > (In reply to comment #5) > > (From update of attachment 125562 [details] [details]) > > It looks ok to me... > > > > maybe our DRT support testing this, Rob? > > The code looks fine to me too. I'll check whether DRT supports about: > Cheers, > > Rob. Thanks, Rob:) Comment on attachment 125562 [details]
Patch
The code looks fine. Can you make a unit test for this, since DRT is not suitable here?
Comment on attachment 125562 [details] Patch Clearing flags on attachment: 125562 Committed r106810: <http://trac.webkit.org/changeset/106810> All reviewed patches have been landed. Closing bug. |