Bug 76355

Summary: The C calling convention logic in DFG::SpeculativeJIT should be available even when not generating code for the DFG speculative path
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch
none
the patch
mitz: review+, webkit-ews: commit-queue-
the patch none

Filip Pizlo
Reported 2012-01-15 19:19:42 PST
This will accomplish two things: 1) Reduce the size of the SpeculativeJIT header. 2) Make it easier to plant calls to C code in stubs generated by compilers other than the DFG::SpeculativeJIT.
Attachments
the patch (64.42 KB, patch)
2012-01-15 19:23 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (65.20 KB, patch)
2012-01-15 19:27 PST, Filip Pizlo 		mitz: review+
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
the patch (65.18 KB, patch)
2012-01-15 19:57 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-01-15 19:23:09 PST
Created attachment 122581 [details] the patch
Filip Pizlo
Comment 2 2012-01-15 19:27:28 PST
Created attachment 122582 [details] the patch Figured I should write a change log.
Early Warning System Bot
Comment 3 2012-01-15 19:47:42 PST
Comment on attachment 122582 [details] the patch Attachment 122582 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11253051
Filip Pizlo
Comment 4 2012-01-15 19:57:41 PST
Created attachment 122584 [details] the patch Pretty sure I fixed the Qt build. Putting patch up to check.
Filip Pizlo
Comment 5 2012-01-15 20:04:20 PST
Landed in http://trac.webkit.org/changeset/105035
Filip Pizlo
Comment 6 2012-01-15 20:05:12 PST
<rdar://problem/10698059>
Note You need to log in before you can comment on or make changes to this bug.