Bug 76355

Summary: The C calling convention logic in DFG::SpeculativeJIT should be available even when not generating code for the DFG speculative path
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch
none
the patch
mitz: review+, webkit-ews: commit-queue-
the patch none

Description Filip Pizlo 2012-01-15 19:19:42 PST
This will accomplish two things:

1) Reduce the size of the SpeculativeJIT header.

2) Make it easier to plant calls to C code in stubs generated by compilers other than the DFG::SpeculativeJIT.
Comment 1 Filip Pizlo 2012-01-15 19:23:09 PST
Created attachment 122581 [details]
the patch
Comment 2 Filip Pizlo 2012-01-15 19:27:28 PST
Created attachment 122582 [details]
the patch

Figured I should write a change log.
Comment 3 Early Warning System Bot 2012-01-15 19:47:42 PST
Comment on attachment 122582 [details]
the patch

Attachment 122582 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/11253051
Comment 4 Filip Pizlo 2012-01-15 19:57:41 PST
Created attachment 122584 [details]
the patch

Pretty sure I fixed the Qt build.  Putting patch up to check.
Comment 5 Filip Pizlo 2012-01-15 20:04:20 PST
Landed in http://trac.webkit.org/changeset/105035
Comment 6 Filip Pizlo 2012-01-15 20:05:12 PST
<rdar://problem/10698059>