Summary: | [GTK] [WK2] WebKitPrivate should include the entire WebKit2 C API | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Martin Robinson <mrobinson> | ||||
Component: | WebKitGTK | Assignee: | Martin Robinson <mrobinson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cgarcia, gustavo, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Martin Robinson
2012-01-15 09:17:56 PST
Created attachment 122679 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 122679 [details]
Patch
LGTM
Comment on attachment 122679 [details]
Patch
OK, although I'm curious: we kinda went the opposite way of splitting a big private header into several private headers in wk1, why is this better?
(In reply to comment #4) > (From update of attachment 122679 [details]) > OK, although I'm curious: we kinda went the opposite way of splitting a big private header into several private headers in wk1, why is this better? WebKitPrivate contains only common private stuff, we still have a Private.h for every object that has private api. Comment on attachment 122679 [details]
Patch
Thanks for the review! In this case the GObject API is sort of like a client and the WebKit2 C headers are a bit like including <webkit/webkit.h> for WebKit1.
Comment on attachment 122679 [details] Patch Clearing flags on attachment: 122679 Committed r105158: <http://trac.webkit.org/changeset/105158> All reviewed patches have been landed. Closing bug. |