Bug 76345

Summary: [GTK] [WK2] WebKitPrivate should include the entire WebKit2 C API
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, gustavo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Martin Robinson
Reported 2012-01-15 09:17:56 PST
This will prevent API files from including it piecemeal.
Attachments
Patch (6.96 KB, patch)
2012-01-16 13:51 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2012-01-16 13:51:50 PST
Created attachment 122679 [details] Patch
WebKit Review Bot
Comment 2 2012-01-16 13:54:47 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Carlos Garcia Campos
Comment 3 2012-01-16 23:45:46 PST
Comment on attachment 122679 [details] Patch LGTM
Gustavo Noronha (kov)
Comment 4 2012-01-17 04:04:07 PST
Comment on attachment 122679 [details] Patch OK, although I'm curious: we kinda went the opposite way of splitting a big private header into several private headers in wk1, why is this better?
Carlos Garcia Campos
Comment 5 2012-01-17 04:07:49 PST
(In reply to comment #4) > (From update of attachment 122679 [details]) > OK, although I'm curious: we kinda went the opposite way of splitting a big private header into several private headers in wk1, why is this better? WebKitPrivate contains only common private stuff, we still have a Private.h for every object that has private api.
Martin Robinson
Comment 6 2012-01-17 06:40:49 PST
Comment on attachment 122679 [details] Patch Thanks for the review! In this case the GObject API is sort of like a client and the WebKit2 C headers are a bit like including <webkit/webkit.h> for WebKit1.
WebKit Review Bot
Comment 7 2012-01-17 07:38:00 PST
Comment on attachment 122679 [details] Patch Clearing flags on attachment: 122679 Committed r105158: <http://trac.webkit.org/changeset/105158>
WebKit Review Bot
Comment 8 2012-01-17 07:38:05 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.