Summary: | Port Mozilla's Graph Server | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||
Component: | Tools / Tests | Assignee: | Ryosuke Niwa <rniwa> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, evan, tony, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 10266 | ||||||||
Attachments: |
|
Description
Ryosuke Niwa
2012-01-13 14:33:37 PST
I've made a lot of progress over the weekend. I wrote an app-engine backend and deployed it on http://webkit-perf.appspot.com/ (no dashboard support yet) and also did some refactoring of the frontend code, which I'm trying to upstream on https://bugzilla.mozilla.org/show_bug.cgi?id=718872 and elsewhere. See http://webkit-perf.appspot.com/graph.html for a demo. Created attachment 123817 [details]
Adds the WebKit backend & config.js
Attachment 123817 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Websites/perf-webkit.appspot..." exit_code: 1
Websites/perf-webkit.appspot.com/manifest_handler.py:42: multiple statements on one line (semicolon) [pep8/E702] [5]
Websites/perf-webkit.appspot.com/dashboard_handler.py:58: multiple statements on one line (semicolon) [pep8/E702] [5]
Websites/perf-webkit.appspot.com/create_handler.py:44: multiple statements on one line (semicolon) [pep8/E702] [5]
Websites/perf-webkit.appspot.com/runs_handler.py:87: multiple statements on one line (semicolon) [pep8/E702] [5]
Total errors found: 4 in 12 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 124010 [details]
Fixed a bunch of bugs
I presume you're just looking for a rubberstamp here. Attachment 124010 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Websites/webkit-perf.appspot..." exit_code: 1
Websites/webkit-perf.appspot.com/runs_handler.py:87: multiple statements on one line (semicolon) [pep8/E702] [5]
Websites/webkit-perf.appspot.com/create_handler.py:44: multiple statements on one line (semicolon) [pep8/E702] [5]
Websites/webkit-perf.appspot.com/manifest_handler.py:42: multiple statements on one line (semicolon) [pep8/E702] [5]
Websites/webkit-perf.appspot.com/dashboard_handler.py:58: multiple statements on one line (semicolon) [pep8/E702] [5]
Total errors found: 4 in 13 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #5) > I presume you're just looking for a rubberstamp here. Yes. This thing is already up and running so the only difference review can make is whether it's in webkit repository or not. Comment on attachment 124010 [details]
Fixed a bunch of bugs
Ok. I would have put this in the "Tools" folder, but this is fine now.
Committed r105971: <http://trac.webkit.org/changeset/105971> |