Bug 76287

Summary: Coding standard violation: Rename static members with "s_" prefix.
Product: WebKit Reporter: Eugene Girard <girard>
Component: WebKit Misc.Assignee: Eugene Girard <girard>
Status: RESOLVED WONTFIX    
Severity: Trivial CC: cc-bugs, jamesr, macpherson, webkit.review.bot
Priority: P4    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch jamesr: review-

Eugene Girard
Reported 2012-01-13 10:44:11 PST
(Here come the code standards police;) The code standard asks for static member variables to be named with an "s_" prefix. A number of files violate this. This is a trivial (and low impact) change, affecting private member variables and internal access to the same.
Attachments
Patch (35.38 KB, patch)
2012-01-13 10:51 PST, Eugene Girard 		jamesr: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eugene Girard
Comment 1 2012-01-13 10:51:18 PST
Created attachment 122455 [details] Patch
Eugene Girard
Comment 2 2012-01-13 10:53:09 PST
Comment on attachment 122455 [details] Patch Trivial code change. Renames a number of private member variables to agree with the coding standard. http://www.webkit.org/coding/coding-style.html
James Robinson
Comment 3 2012-01-13 12:27:08 PST
Comment on attachment 122455 [details] Patch Our general project policy is to not do bulk style changes without any other changes since it's mostly unnecessary churn. It's generally fine to fix the style in any area of the code that you are patching for other reasons.
Eugene Girard
Comment 4 2012-01-16 10:59:03 PST
Well, that's disappointing. I can't imagine any of these ever getting fixed. Perhaps we should consider either making check-webkit-style police this, or removing that line from our coding standard. Closing as wontfix.
Note You need to log in before you can comment on or make changes to this bug.