Bug 76271

Summary:

JSC/DOM bindings: Reduce HandleHeap churn in cacheWrapper().

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

WebCore JavaScript

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, darin

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Andreas Kling 2012-01-13 06:19:19 PST

JSC/DOM bindings: Reduce HandleHeap churn in cacheWrapper().

Comment 1 Andreas Kling 2012-01-13 06:21:17 PST

Created attachment 122422 [details]
Patch

Comment 2 Andreas Kling 2012-01-13 08:35:40 PST

Comment on attachment 122422 [details]
Patch

Clearing flags on attachment: 122422

Committed r104941: <http://trac.webkit.org/changeset/104941>

Comment 3 Andreas Kling 2012-01-13 08:35:50 PST

All reviewed patches have been landed.  Closing bug.

Comment 4 Darin Adler 2012-01-13 08:41:42 PST

By the way, another way to do this that might be less roundabout would be to add a function that does assignment for JSC::Weak. Something named “set” or “assign”. We’d use that instead of “construct and swap”.

I have a possibly-unfounded suspicion move semantics in C++11 also would have helped do this in a more elegant way, but we can’t rely on that at this time.