|Summary:||[Mac][DRT] should allow query string for the file URL.|
|Product:||WebKit||Reporter:||Hajime Morrita <morrita>|
|Component:||Tools / Tests||Assignee:||Hajime Morrita <morrita>|
|Severity:||Normal||CC:||aroben, rniwa, tony, webkit.review.bot|
|Version:||528+ (Nightly build)|
|Bug Depends on:|
Description Hajime Morrita 2012-01-12 21:50:05 PST
This is a part of effort to run Dromaeo on DRT. Dromaeo select the subset of test to run by reading the query string. But DRT cannot pass it because file urls don't support query string. So we need some way to give a context other than query string to run the test. By injecting some script from outside, we can start the script by emulating user operation. This kind of automation helper would be helpful to run existing testcases. We can do - invoking layoutTestController without touching the page source. - emulating user operation like clicking - modifying page DOM to format the report.
Comment 1 Ryosuke Niwa 2012-01-12 22:04:18 PST
Can we run the tests inside an iframe?
Comment 2 Hajime Morrita 2012-01-12 22:05:34 PST
(In reply to comment #1) > Can we run the tests inside an iframe? Ah, that looks better idea actually. I'll try.
Comment 3 Tony Chang 2012-01-13 10:12:03 PST
FWIW, I am able to load file:///test.html?test and file:///test.html#test in Safari Mac and Chrome Linux. window.location seems to have properly parsed the query string and the fragment.
Comment 4 Hajime Morrita 2012-01-15 17:00:50 PST
(In reply to comment #3) > FWIW, I am able to load file:///test.html?test and file:///test.html#test in Safari Mac and Chrome Linux. window.location seems to have properly parsed the query string and the fragment. Hmm interesting. May be we can fix DRT to handle it. Its Filename to URl conversion look doubtful.
Comment 5 Hajime Morrita 2012-01-16 18:58:30 PST
Created attachment 122702 [details] Ultra trivial one-line change
Comment 6 WebKit Review Bot 2012-01-17 17:16:44 PST
Comment on attachment 122702 [details] Ultra trivial one-line change Clearing flags on attachment: 122702 Committed r105218: <http://trac.webkit.org/changeset/105218>
Comment 7 WebKit Review Bot 2012-01-17 17:16:49 PST
All reviewed patches have been landed. Closing bug.
Comment 8 Adam Roben (:aroben) 2012-01-18 11:04:02 PST
Are you planning to add this ability to other ports of DRT, and to WebKitTestRunner?
Comment 9 Hajime Morrita 2012-01-18 18:00:23 PST
Hi Adam, thank you for your interest! (In reply to comment #8) > Are you planning to add this ability to other ports of DRT, and to WebKitTestRunner? I don't have any concrete plan yet. But it should be done when we add perf tests on the waterfall. I'm currently focusing on ensuring the feasibility of the idea, that is to run third party perf tests on DRT. So any help would be appreciated ;-)