Summary: | [Mac][DRT] should allow query string for the file URL. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hajime Morrita <morrita> | ||||
Component: | Tools / Tests | Assignee: | Hajime Morrita <morrita> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aroben, rniwa, tony, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 76156 | ||||||
Attachments: |
|
Description
Hajime Morrita
2012-01-12 21:50:05 PST
Can we run the tests inside an iframe? (In reply to comment #1) > Can we run the tests inside an iframe? Ah, that looks better idea actually. I'll try. FWIW, I am able to load file:///test.html?test and file:///test.html#test in Safari Mac and Chrome Linux. window.location seems to have properly parsed the query string and the fragment. (In reply to comment #3) > FWIW, I am able to load file:///test.html?test and file:///test.html#test in Safari Mac and Chrome Linux. window.location seems to have properly parsed the query string and the fragment. Hmm interesting. May be we can fix DRT to handle it. Its Filename to URl conversion look doubtful. Created attachment 122702 [details]
Ultra trivial one-line change
Comment on attachment 122702 [details] Ultra trivial one-line change Clearing flags on attachment: 122702 Committed r105218: <http://trac.webkit.org/changeset/105218> All reviewed patches have been landed. Closing bug. Are you planning to add this ability to other ports of DRT, and to WebKitTestRunner? Hi Adam, thank you for your interest! (In reply to comment #8) > Are you planning to add this ability to other ports of DRT, and to WebKitTestRunner? I don't have any concrete plan yet. But it should be done when we add perf tests on the waterfall. I'm currently focusing on ensuring the feasibility of the idea, that is to run third party perf tests on DRT. So any help would be appreciated ;-) |