|Summary:||NSURL to KURL conversion shouldn't turn raw paths into file URLs|
|Product:||WebKit||Reporter:||Alexey Proskuryakov <ap>|
|Component:||Platform||Assignee:||Alexey Proskuryakov <ap>|
|Version:||528+ (Nightly build)|
|Bug Depends on:||78280|
Description Alexey Proskuryakov 2012-01-12 17:19:24 PST
This creates ways for strings that didn't look like file URLs at first to become file URLs after security checks have cleared them. I tracked the origins of this code to <http://trac.webkit.org/changeset/4662>. It's not clear if there was any reason for doing this - I couldn't find any evidence of any Foundation or AppKit methods doing much with such NSURLs.
Comment 1 Alexey Proskuryakov 2012-01-12 17:22:00 PST
Created attachment 122345 [details] proposed patch I suggest waiting to see if any non-Safari clients break because of this. We can then add more relaxed conversion for APIs that are used this way.
Comment 2 Darin Adler 2012-01-12 17:25:44 PST
Comment on attachment 122345 [details] proposed patch Seems good to do this. I agree we can add code to add "file:" prefix in the WebKit level later if we find we need it for compatibility.
Comment 3 Alexey Proskuryakov 2012-01-12 17:27:47 PST