Bug 76226

Summary: table border spacing test for CSS3 calc
Product: WebKit Reporter: Mike Lawther <mikelawther>
Component: New BugsAssignee: Mike Lawther <mikelawther>
Status: RESOLVED FIXED    
Severity: Normal CC: jchaffraix, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 16662    
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Mike Lawther 2012-01-12 16:53:57 PST 
table border spacing test for CSS3 calc
Comment 1 Mike Lawther 2012-01-12 16:55:51 PST 
Created attachment 122339 [details]
Patch
Comment 2 Julien Chaffraix 2012-01-24 15:09:36 PST 
Comment on attachment 122339 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122339&action=review

> LayoutTests/css3/calc/table-border-spacing.html:5
> +        vertical-align: top; 

Nit: This line is not be needed for the test.

> LayoutTests/css3/calc/table-border-spacing.html:15
> +        position: relative 

Ditto.
Comment 3 Mike Lawther 2012-01-24 22:27:45 PST 
Comment on attachment 122339 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122339&action=review

Thanks for the review Julien!

>> LayoutTests/css3/calc/table-border-spacing.html:5
>> +        vertical-align: top; 
> 
> Nit: This line is not be needed for the test.

Done.

>> LayoutTests/css3/calc/table-border-spacing.html:15
>> +        position: relative 
> 
> Ditto.

Done.
Comment 4 Mike Lawther 2012-01-24 22:28:20 PST 
Created attachment 123884 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-01-25 04:39:18 PST 
Comment on attachment 123884 [details]
Patch for landing

Clearing flags on attachment: 123884

Committed r105869: <http://trac.webkit.org/changeset/105869>
Comment 6 WebKit Review Bot 2012-01-25 04:39:22 PST 
All reviewed patches have been landed.  Closing bug.