Bug 76215 – webkitpy: make mapping a port name to a port completely data-driven

• Component: New Bugs
• Status: RESOLVED FIXED

[Dirk Pranke]

webkitpy: make mapping a port name to a port completely data-driven

[Dirk Pranke]

Created attachment 122312 [details]
Patch

[Dirk Pranke]

Okay, this is roughly the last patch needed to finish cleaning up how ports are constructed (at least my best stab at it). It's a bit large; I could break the cleanup in factory.py out into a separate patch but I thought leaving it in would be helpful to show the final end state as you're looking at the other changes (including how port_name and determine_full_port_name are used).

With this change, adding a new implementation requires adding one line to factory.py (in the PORT_CLASSES list) plus implementing the actual port class.

Also, with the exception of supporting the --chromium flag and the 'chromium-gpu' port name, the only non-data-driven logic in the factory class is the logic for picking a default port for a given platform.

Thoughts?

[Adam Barth]

I'm excited about the idea behind this patch, but this patch is slightly larger than I can chew on at the moment.  I'll look again this evening when things are less hectic.

[Dirk Pranke]

no hurry, and I'll be able to try and split it up into two or three chunks if that'll help. Let me know after you take another (quick?) look.

[Dirk Pranke]

I will note that this is the last patch in the series so it's not blocking anything else I'm working on. We can take our time w/ this ...

[Dirk Pranke]

closing; all dependent bugs have landed.