|Summary:||use unsigned bitfields when storing enums in them, to avoid mangling on win32 (was causing all layout to be RTL)|
|Product:||WebKit||Reporter:||Maciej Stachowiak <mjs>|
|Component:||WebKit Misc.||Assignee:||Maciej Stachowiak <mjs>|
|OS:||OS X 10.4|
Description Maciej Stachowiak 2006-03-05 17:53:19 PST
In MSVC, enums are signed, as are bitfields containing them. This often makes values at the extreme end of the enum range go negative, so they fail equality comparisons. I fixed this by always using unsigned for bitfields that hold enums, unless the enum actually uses negative values.
Comment 1 Maciej Stachowiak 2006-03-05 17:55:24 PST
Created attachment 6880 [details] take 1 (kinda ugly)
Comment 2 Darin Adler 2006-03-05 20:17:57 PST
Comment on attachment 6880 [details] take 1 (kinda ugly) r=me I didn't spot any problems. The trick with a change like this is to do enough testing.
Comment 3 Darin Adler 2006-03-05 20:23:36 PST
Maciej landed this.