|Summary:||Make the new WTF module build on Qt|
|Product:||WebKit||Reporter:||Simon Hausmann <hausmann>|
|Component:||WebKit Qt||Assignee:||Simon Hausmann <hausmann>|
|Severity:||Normal||CC:||abarth, eric, levin+threading, menard, ossy, vestbo, webkit.review.bot|
|Version:||528+ (Nightly build)|
|Bug Depends on:||76179|
Description Simon Hausmann 2012-01-12 03:17:01 PST
Comment 2 Simon Hausmann 2012-01-12 06:57:47 PST
With this patch it should be possible to move files from the old WTF location to the new one without changing the Qt build system, due to the use of VPATH in WTF.pro. Files can be moved individually or in one big move, but each time qmake needs to be re-run on the bot for this to work :/. Either by touching the .pro/.pri file in the change or maybe through something else in the build system?
Comment 3 Tor Arne Vestbø 2012-01-12 07:02:29 PST
Comment on attachment 122232 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122232&action=review nice. i think the move will be in one go, so a single force-clean should be fine > Source/WTF/WTF.pri:3 > +# and for targets that depend in some way on NEWWTF. WTF, not NEWWTF
Comment 4 Simon Hausmann 2012-01-12 07:04:24 PST
(In reply to comment #3) > (From update of attachment 122232 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=122232&action=review > > nice. i think the move will be in one go, so a single force-clean should be fine Ok. good. > > Source/WTF/WTF.pri:3 > > +# and for targets that depend in some way on NEWWTF. > > WTF, not NEWWTF Oops, fixing.
Comment 6 Simon Hausmann 2012-01-12 07:22:25 PST
Committed r104825: <http://trac.webkit.org/changeset/104825>
Comment 7 Adam Barth 2012-01-12 12:28:58 PST
Comment 8 Eric Seidel (no email) 2012-01-12 12:43:17 PST
We talked about doing this for all the ports. If it's easy to do for others, we definitely should. It makes the final move trivial.