Bug 7616

Summary: get all references to KJS::Node out of internal.h
Product: WebKit Reporter: Darin Adler <darin>
Component: JavaScriptCoreAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
patch with change log mjs: review+

Darin Adler
Reported 2006-03-05 11:51:34 PST
While working on removing the "Impl" suffix from class names in WebCore, I discovered a conflict between KJS::Node and WebCore::Node. This happens because KJS::Node is exposed to WebCore. But it should not be. The best fix would be to not use "internal.h" at all in WebCore. This is impractical at the moment because it's used for a number of different reasons. Instead, I factored out the only thing in "internal.h" that needs KJS::Node out into a separate file. It's the parser, and the new file is "Parser.h". This fits with our future direction for JavaScriptCore of naming files after the classes in them.
Attachments
patch with change log (49.96 KB, patch)
2006-03-05 11:53 PST, Darin Adler 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2006-03-05 11:53:54 PST
Created attachment 6875 [details] patch with change log
Note You need to log in before you can comment on or make changes to this bug.