Summary: | Merge 'Getter'/'Setter' attributes into 'Accessor' | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gavin Barraclough <barraclough> | ||||||
Component: | JavaScriptCore | Assignee: | Gavin Barraclough <barraclough> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ossy, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Gavin Barraclough
2012-01-11 19:41:44 PST
Created attachment 122159 [details]
Fix
Attachment 122159 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/runtime/JSObject.h:69: One space before end of line comments [whitespace/comments] [5]
Total errors found: 1 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
It caused an assertion on SL, GTK and Qt: ASSERTION FAILED: value.isGetterSetter() == !!(attributes & Accessor) ../../../../Source/JavaScriptCore/runtime/PropertyDescriptor.cpp(90) : void JSC::PropertyDescriptor::setDescriptor(JSC::JSValue, unsigned int) (In reply to comment #4) > It caused an assertion on SL, GTK and Qt: > > ASSERTION FAILED: value.isGetterSetter() == !!(attributes & Accessor) > ../../../../Source/JavaScriptCore/runtime/PropertyDescriptor.cpp(90) : void JSC::PropertyDescriptor::setDescriptor(JSC::JSValue, unsigned int) I forgot to mention the name of the test: fast/dom/getter-on-window-object2.html Sorry I missed this ossy, investigating. Created attachment 122325 [details]
Fix
|