Bug 76108

Summary: IndexedDB: Methods should throw TRANSACTION_INACTIVE_ERR when transaction is completed/aborted
Product: WebKit Reporter: Joshua Bell <jsbell>
Component: New BugsAssignee: Joshua Bell <jsbell>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dgrogan, ojan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Joshua Bell
Reported 2012-01-11 15:03:30 PST
IndexedDB: Methods should throw TRANSACTION_INACTIVE_ERR when transaction is completed/aborted
Attachments
Patch (39.29 KB, patch)
2012-01-11 15:06 PST, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Patch (39.32 KB, patch)
2012-01-11 15:27 PST, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Patch (39.67 KB, patch)
2012-01-11 16:16 PST, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Joshua Bell
Comment 1 2012-01-11 15:06:41 PST
Created attachment 122103 [details] Patch
Joshua Bell
Comment 2 2012-01-11 15:27:27 PST
Created attachment 122110 [details] Patch
Joshua Bell
Comment 3 2012-01-11 15:29:07 PST
Comment on attachment 122110 [details] Patch Oops - I had my more detailed changelog saved locally but it didn't make it into the patch somehow.
Tony Chang
Comment 4 2012-01-11 15:50:17 PST
Comment on attachment 122103 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122103&action=review > Source/WebCore/storage/IDBDatabaseException.h:55 > + TRANSACTION_INACTIVE_ERR = IDBDatabaseExceptionOffset + 7, > + ABORT_ERR = IDBDatabaseExceptionOffset + 8, > + READ_ONLY_ERR = IDBDatabaseExceptionOffset + 9, It's sufficient to set the first value to IDBDatabaseExceptionOffset and the rest will increment from there.
Joshua Bell
Comment 5 2012-01-11 16:16:14 PST
Created attachment 122117 [details] Patch
Joshua Bell
Comment 6 2012-01-11 16:17:14 PST
Comment on attachment 122117 [details] Patch Thanks, good to tidy while I'm in there.
WebKit Review Bot
Comment 7 2012-01-11 17:03:03 PST
Comment on attachment 122117 [details] Patch Clearing flags on attachment: 122117 Committed r104771: <http://trac.webkit.org/changeset/104771>
WebKit Review Bot
Comment 8 2012-01-11 17:03:09 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.