WebKit fails IETC Override_Property_Setter_High (both JSC and V8)

• Component: Tools / Tests
• Status: RESOLVED CONFIGURATION CHANGED

[Eric Seidel (no email)]

WebKit fails IETC Override_Property_Setter_High (both JSC and V8)

http://samples.msdn.microsoft.com/ietestcenter/dominheritance/showdominheritancetest.htm?Override_Property_Setter_High

Passes in FF.  There seem to be a number of Object.defineProperty bugs on file, maybe this is just a dupe of one of them.

The test is doing the following:

        var setValue = false;
        if (Object.defineProperty) {
            Object.defineProperty(Node.prototype, "nodeName", {
                set: function () {
                    setValue = true;
                }
            });
        }
        var div = document.createElement("div");
        div.nodeName = "foo";
        if (setValue) {
            document.getElementById("testresult").innerHTML = "Pass";
        }

CCing the JavaScript ninjas.

See also bug 76106 which is about the "getter" variant of this test.

[Geoffrey Garen]

I think this is really a test of the DOM API. Whether a setter on the prototype overrides the DOM API depends on whether the DOM API is expressed as a setter on the DOM object's prototype or a direct property on the DOM object.

[Zan Dobersek]

I guess this boils down to the differences between WebKitIDL and WebIDL, as explained here:
http://trac.webkit.org/wiki/WebKitIDL#V8Unforgeable

[Zan Dobersek]

This bug and bug #76106 should probably be marked as a duplicate of bug #49739 as many other bugs have been before.

[Ahmad Saleem]

@Alexey - is this applicable anymore?

[Alexey Shvayka]

(In reply to Eric Seidel (no email) from comment #0)
> WebKit fails IETC Override_Property_Setter_High (both JSC and V8)
> 
> http://samples.msdn.microsoft.com/ietestcenter/dominheritance/
> showdominheritancetest.htm?Override_Property_Setter_High

The link is no longer alive yet we pass the inline test case since bindings redesign circa 2015. Redefinition of DOM properties is heavily covered by both WPT and our tests.