Summary: | Implement font-variant-ligatures: {no-}common-ligatures | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | mitz | ||||
Component: | Text | Assignee: | mitz | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | macpherson, webkit.review.bot | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
mitz
2012-01-11 14:31:30 PST
Created attachment 122101 [details]
Parse font-variant-ligatures and respect the common-ligatures value keywords
Comment on attachment 122101 [details] Parse font-variant-ligatures and respect the common-ligatures value keywords View in context: https://bugs.webkit.org/attachment.cgi?id=122101&action=review > Source/WebCore/css/CSSStyleApplyProperty.cpp:759 > + if (value->isPrimitiveValue()) > + ASSERT(static_cast<CSSPrimitiveValue*>(value)->getIdent() == CSSValueNormal); This seems like it should go in the else block within an !ASSERTIONS_DISABLED. > Source/WebCore/platform/graphics/FontDescription.h:196 > + unsigned m_commonLigaturesState : 3; > + unsigned m_discretionaryLigaturesState : 3; > + unsigned m_historicalLigaturesState : 3; Do you really need three bits here? Committed <http://trac.webkit.org/r104786>. |